Uh oh!
There was an error while loading. Please reload this page.
[stable25] invalidate existing tokens when deleting an oauth client - #37231
Merged
Conversation
backportbot-nextcloudBot
requested review from
come-nc, individual-it and julien-ncMarch 15, 2023 10:42
Merged
come-ncforce-pushed
the
backport/36033/stable25
branch
from
March 15, 2023 13:07
fae11df to
58fb023Comparecome-nc
approved these changes
Mar 15, 2023
come-nc
marked this pull request as ready for review
March 15, 2023 13:10
blizzz
requested changes
Mar 15, 2023
| public function deleteClient(int $id): JSONResponse { | ||
| $client = $this->clientMapper->getByUid($id); | ||
| $this->userManager->callForAllUsers(function (IUser $user) use ($client) { |
Member
There was a problem hiding this comment.
do not run against all users, but only against known ones (callForSeenUsers).
Also, this should not run in a user request context, only on the background, as it may take ages.
individual-itforce-pushed
the
backport/36033/stable25
branch
from
April 17, 2023 09:02
58fb023 to
d905b41Compare
This was referenced Apr 17, 2023
Merged
blizzz
commented
May 17, 2023
Member
moving to 25.0.8. What is the state with this PR? |
individual-it
commented
May 17, 2023
Contributor
all done from my point of view, see discussion in #37230 |
individual-itforce-pushed
the
backport/36033/stable25
branch
from
May 19, 2023 07:09
d905b41 to
c2f71bfCompare Merged
blizzz
reviewed
Jun 13, 2023
Uh oh!
There was an error while loading. Please reload this page.
blizzz
reviewed
Jun 13, 2023
Uh oh!
There was an error while loading. Please reload this page.
blizzz
approved these changes
Jun 14, 2023
blizzz
commented
Jun 14, 2023
Member
@individual-it conflicts 😩 |
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
individual-itforce-pushed
the
backport/36033/stable25
branch
from
June 15, 2023 07:36
9922fee to
28b9cfbCompare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
individual-it
enabled auto-merge
June 15, 2023 07:47
individual-it
commented
Jun 15, 2023
Contributor
@blizzz fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #36033