Skip to content

fix undefined method getExtStorageHome() - #37346

Merged
blizzz merged 1 commit into
masterfrom
fix/34557/undefined-getExtStorageHome
Mar 27, 2023
Merged

fix undefined method getExtStorageHome()#37346
blizzz merged 1 commit into
masterfrom
fix/34557/undefined-getExtStorageHome

Conversation

@blizzz

@blizzzblizzz commented Mar 22, 2023

Copy link
Copy Markdown
Member

Summary

  • adds a type check
  • defines missing method in OfflineUser

Checklist

- adds a type check
- defines missing method in OfflineUser
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added this to the Nextcloud 27 milestone Mar 22, 2023
@blizzz
blizzz requested review from a team, ArtificialOwl, come-nc, icewind1991 and miaulalala and removed request for a teamMarch 22, 2023 12:56
@blizzzblizzz mentioned this pull request Mar 22, 2023
9 tasks

@miaulalalamiaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@miaulalala

Copy link
Copy Markdown
Contributor

/backport to stable25

@miaulalala

Copy link
Copy Markdown
Contributor

/backport to stable26

@miaulalala

Copy link
Copy Markdown
Contributor

/backport to stable24

@blizzz
blizzz merged commit 0be7548 into masterMar 27, 2023
@blizzz
blizzz deleted the fix/34557/undefined-getExtStorageHome branch March 27, 2023 13:33
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable24 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable24
git pull origin/stable24
# Create the new backport branch
git checkout -b fix/foo-stable24
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable24

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@miaulalala

Copy link
Copy Markdown
Contributor

/backport to stable25

@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@blizzz

Copy link
Copy Markdown
MemberAuthor

/skjnldsv-backport to stable26

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: ldap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Can't delete ldap users

4 participants

@blizzz@miaulalala@come-nc@skjnldsv