Skip to content

Fix : Hides hidden files an folder in grid view - #37599

Closed
Jerome-Herbinet wants to merge 2 commits into
nextcloud:masterfrom
Jerome-Herbinet:patch-22
Closed

Fix : Hides hidden files an folder in grid view#37599
Jerome-Herbinet wants to merge 2 commits into
nextcloud:masterfrom
Jerome-Herbinet:patch-22

Conversation

@Jerome-Herbinet

Copy link
Copy Markdown
Member

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

Summary

Hides hidden files an folder in grid view (replace calls to ".hidden" by ".hidden-file" class)

TODO

  • ...

Checklist

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@szaimenszaimen added this to the Nextcloud 27 milestone Apr 5, 2023
@szaimenszaimen added the 3. to review Waiting for reviews label Apr 5, 2023
@szaimen
szaimen requested review from a team, Pytal, artonge, miaulalala and szaimen and removed request for a teamApril 5, 2023 12:09

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder wasnt this fixed with #37269?

@Jerome-Herbinet

Copy link
Copy Markdown
MemberAuthor

I wonder wasnt this fixed with #37269?

@szaimen I use NC 25.0.5 and the problem still occurs. So, #37269 and/or #37287 don't solve the issue in the case I describe, or it's not solving the same problem.

@szaimen

Copy link
Copy Markdown
Contributor

@szaimen I use NC 25.0.5 and the problem still occurs. So, #37269 and/or #37287 don't solve the issue in the case I describe, or it's not solving the same problem.

Did you already try to clear the browser cache?

@Jerome-Herbinet

Copy link
Copy Markdown
MemberAuthor

@szaimen I use NC 25.0.5 and the problem still occurs. So, #37269 and/or #37287 don't solve the issue in the case I describe, or it's not solving the same problem.

Did you already try to clear the browser cache?

Yes I did.

@szaimen

szaimen commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Yes I did.

Apparently #37287 will be included in 25.0.6.

@Jerome-Herbinet

Copy link
Copy Markdown
MemberAuthor

OK, do I close this PR now, or do we wait for NC 25.0.6 to do it ? (after checking front-end behaviour) ?

@szaimen

Copy link
Copy Markdown
Contributor

I'd wait for 25.0.6 and 26.0.1 first

This was referenced May 3, 2023
@blizzzblizzz mentioned this pull request May 17, 2023
@blizzzblizzz modified the milestones: Nextcloud 27, Nextcloud 28May 23, 2023
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@skjnldsv

Copy link
Copy Markdown
Member

Fixed with 28 and above

@skjnldsvskjnldsv removed the 3. to review Waiting for reviews label Feb 23, 2024
@skjnldsvskjnldsv removed this from the Nextcloud 29 milestone Feb 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Jerome-Herbinet@szaimen@skjnldsv@blizzz