Skip to content

fix(dav): Parse sender PARTSTAT in REPLYs - #37645

Merged
szaimen merged 1 commit into
masterfrom
fix/improve-imip-emails
Apr 17, 2023
Merged

fix(dav): Parse sender PARTSTAT in REPLYs#37645
szaimen merged 1 commit into
masterfrom
fix/improve-imip-emails

Conversation

@miaulalala

@miaulalalamiaulalala commented Apr 7, 2023

Copy link
Copy Markdown
Contributor

Summary

Parse the PARTSTAT of the sender if the iMIP method is REPLY. Will make iMIP emails more fancy and tell the recipient if the attendee has accepted, declined or tentatively accepted in the mail itself:

BeforeAfter
imageimage

(Strings need to be translated yet)

Checklist

@miaulalalamiaulalala added the 3. to review Waiting for reviews label Apr 7, 2023
@miaulalalamiaulalala added this to the Nextcloud 26.0.1 milestone Apr 7, 2023
@miaulalalamiaulalala self-assigned this Apr 7, 2023
@miaulalala

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

Comment threadapps/dav/lib/CalDAV/Schedule/IMipService.php Fixed
@miaulalalamiaulalala added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 7, 2023
Comment threadapps/dav/lib/CalDAV/Schedule/IMipService.php Fixed
Comment threadapps/settings/templates/settings/admin/additional-mail.php Outdated
Comment threadapps/dav/lib/CalDAV/Schedule/IMipService.php Outdated
Comment threadapps/dav/lib/CalDAV/Schedule/IMipService.php
@tcitworld

Copy link
Copy Markdown
Member

Nice improvement!

@miaulalala
miaulalalaforce-pushed the fix/improve-imip-emails branch from 5bc6a41 to cba3838CompareApril 12, 2023 18:18
@skjnldsvskjnldsv mentioned this pull request Apr 13, 2023
8 tasks
@miaulalalamiaulalala added 3. to review Waiting for reviews feature: caldav Related to CalDAV internals and removed 2. developing Work in progress labels Apr 13, 2023

@fabricemousfabricemous left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen it and I think this is best sentence to use

Comment threadapps/settings/templates/settings/admin/additional-mail.php Outdated
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
miaulalalaforce-pushed the fix/improve-imip-emails branch from cba3838 to fd85c86CompareApril 13, 2023 16:55
@miaulalalamiaulalala removed this from the Nextcloud 26.0.1 milestone Apr 13, 2023
@szaimen
szaimen merged commit 6afda50 into masterApr 17, 2023
@szaimen
szaimen deleted the fix/improve-imip-emails branch April 17, 2023 21:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: caldavRelated to CalDAV internals

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Parse the ATTENDEE PARTSTAT for the "REPLY" event invitation email

7 participants

@miaulalala@tcitworld@AndyScherzinger@ChristophWurst@fabricemous@github-advanced-security@szaimen