Skip to content

Really disable versions features when S3 versioning is enabled - #37764

Merged
artonge merged 1 commit into
masterfrom
artonge/fix/disable_versions_feature_s3_versioning
Apr 17, 2023
Merged

Really disable versions features when S3 versioning is enabled#37764
artonge merged 1 commit into
masterfrom
artonge/fix/disable_versions_feature_s3_versioning

Conversation

@artonge

@artongeartonge commented Apr 17, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@artonge
Really disable versions features when S3 versioning is enabled
cca46f1
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artongeartonge self-assigned this Apr 17, 2023
@artongeartonge added bug 3. to review Waiting for reviews feature: versions php Pull requests that update Php code labels Apr 17, 2023
@artonge
artonge requested review from a team, ArtificialOwl, blizzz and icewind1991 and removed request for a teamApril 17, 2023 09:17
@artongeartonge added this to the Nextcloud 27 milestone Apr 17, 2023
@artonge

artonge commented Apr 17, 2023

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable26

szaimen
szaimen approved these changes Apr 17, 2023
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

solracsf
solracsf approved these changes Apr 17, 2023
View reviewed changes

@solracsfsolracsf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@artonge

artonge commented Apr 17, 2023

Copy link
Copy Markdown
CollaboratorAuthor

CI failure unrelated

@artonge
artonge merged commit ed2b28b into masterApr 17, 2023
@artonge
artonge deleted the artonge/fix/disable_versions_feature_s3_versioning branch April 17, 2023 13:32
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 17, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solracsfsolracsfsolracsf approved these changes
@szaimenszaimenszaimen approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@blizzzblizzzAwaiting requested review from blizzzblizzz is a code owner automatically assigned from nextcloud/server-backend

Assignees

@artongeartonge

Labels

3. to reviewWaiting for reviewsbugfeature: versionsphpPull requests that update Php code

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

3 participants

@artonge@solracsf@szaimen