Uh oh!
There was an error while loading. Please reload this page.
Fix: Filter out empty IP addresses in dnsResolve method - #37778
Closed
w9n wants to merge 1 commit into
Closed
Conversation
szaimen
requested review from
a team, ArtificialOwl, blizzz and icewind1991
and removed request for
a teamApril 18, 2023 00:23
w9nforce-pushed
the
fixdns
branch
2 times, most recently
from
April 18, 2023 09:13
a67f7a3 to
d7827d4CompareUh oh!
There was an error while loading. Please reload this page.
This commit resolves an issue where empty IP addresses could be returned by the dnsResolve method due to CNAME recursion. The fix filters out empty IP addresses before returning the result, ensuring that only valid, non-empty IP addresses are used in the addDnsPinning method. Signed-off-by: Robin Winkelewski <w9ncontact@gmail.com>
Author
sorry I dont know what exactly went wrong with the php dns resolver here. I guess with the "fix" it just uses curls dns resolver when it didnt work. |
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
kesselb
commented
Nov 1, 2023
Contributor
Thanks for your pull request 👍 Replaced by #40234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit resolves an issue where empty IP addresses could be returned by the dnsResolve method due to CNAME recursion. The fix filters out empty IP addresses before returning the result, ensuring that only valid, non-empty IP addresses are used in the addDnsPinning method.
TODO
Checklist