Skip to content

Trap focus in dialogs - #37780

Merged
Pytal merged 2 commits into
masterfrom
enh/a11y-focus-dialog
Apr 25, 2023
Merged

Trap focus in dialogs#37780
Pytal merged 2 commits into
masterfrom
enh/a11y-focus-dialog

Conversation

@Pytal

@PytalPytal commented Apr 18, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Focus is now trapped within dialogs

Checklist

@PytalPytal added the 2. developing Work in progress label Apr 18, 2023
@PytalPytal self-assigned this Apr 18, 2023
@PytalPytal mentioned this pull request Apr 18, 2023
Closed
2 tasks
@Pytal
Pytalforce-pushed the enh/a11y-focus-dialog branch from 9a1e917 to 1d6f379CompareApril 21, 2023 02:49
@PytalPytal changed the title [WIP] Trap focus in dialogsTrap focus in dialogsApr 21, 2023
@Pytal
Pytal marked this pull request as ready for review April 21, 2023 02:51
@PytalPytal added 3. to review Waiting for reviews accessibility and removed 2. developing Work in progress labels Apr 21, 2023
@PytalPytal added this to the Nextcloud 27 milestone Apr 21, 2023
@szaimen
szaimen requested review from artonge and removed request for szaimenApril 21, 2023 09:19
@artonge

artonge commented Apr 24, 2023

Copy link
Copy Markdown
Collaborator

@hamza221 is nextcloud/photos#1711 still needed with this PR?

@artongeartonge mentioned this pull request Apr 24, 2023
Merged
@hamza221

hamza221 commented Apr 24, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@hamza221 is nextcloud/photos#1711 still needed with this PR?

it's not :)) , This is a cleaner and better approach

@hamza221hamza221 mentioned this pull request Apr 24, 2023
Merged
@artongeartonge mentioned this pull request Apr 24, 2023
Closed
@artonge

artonge commented Apr 24, 2023

Copy link
Copy Markdown
Collaborator

/backport to stable26

@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 24, 2023
Pytal added 2 commits April 24, 2023 15:40
@Pytal
Add focus-trap
87ae9bb
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Trap focus in dialogs
79310bd
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the enh/a11y-focus-dialog branch from 1d6f379 to 79310bdCompareApril 24, 2023 22:46
@Pytal
Pytal merged commit 721de34 into masterApr 25, 2023
@Pytal
Pytal deleted the enh/a11y-focus-dialog branch April 25, 2023 00:05
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 25, 2023
Merged
1 task
@artongeartonge mentioned this pull request Apr 26, 2023
Closed
@ChristophWurst

ChristophWurst commented Jun 6, 2023

Copy link
Copy Markdown
Member

/backport to stable25

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jun 6, 2023
Merged
1 task
@PytalPytal mentioned this pull request Jul 5, 2023
Closed
This was referenced Jun 2, 2023
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@JuliaKirschenheuterJuliaKirschenheuterAwaiting requested review from JuliaKirschenheuter

Assignees

@PytalPytal

Labels

4. to releaseReady to be released and/or waiting for tests to finishaccessibility

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

5 participants

@Pytal@artonge@hamza221@ChristophWurst@skjnldsv