Sharing: Do not show copy action when user doesn't have permissions

[marcelklehr]

fixes#37729

• Resolves: [Bug]: File copy action is visible even though user doesn't have permission #37729

Screencasts

Before

After

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[artonge]

Shouldn't the user be allowed to copy a file if he can read it?

[marcelklehr]

Shouldn't the user be allowed to copy a file if he can read it?

In the end it's a philosophical question, I guess. Currently, the back-end does not allow this and Jan opined in the relevant ticket, that we should hide the option.

cc @jancborchardt

[artonge]

No, it is rather technical. If I can read the file, then copying is possible, either by copy-pasting, or if the software allows it, with one click.

I also just check and Nautilus is allowing copying read-only files. Same with bash.

[marcelklehr]

No, it is rather technical.

I agree, this is the technical perspective. There is a UX perspective to this in a way. But personally, I'm very unconcerned by which way this goes. Either we fix this in the UI and don't show the option, or we fix it in the backend to make it possible to copy files when the user has read permissions. I'll let you fight this out with @jancborchardt

[skjnldsv]

or we fix it in the backend to make it possible to copy files when the user has read permissions. I'll let you fight this out with @jancborchardt

I think this is the way to go as this is what I would expect from a dav endpoint.
The question here is where does it fail? When you copy, does it fail on the READ check, or on the WRITE permission of the destination folder?

[marcelklehr]

Seems like the permission error stems from here: https://github.com/nextcloud/server/blob/master/apps/dav/lib/DAV/ViewOnlyPlugin.php

[jancborchardt]

Sorry, I assumed the backend was as intended. If not, then I would agree that this is rather something to fix in the backend. :)

[marcelklehr]

> (1 & 2 === 0)
0
> (1 & 2) === 0
true

😡

[come-nc]

I always feel we do not put enough parenthesis in Nextcloud code, I tend to be paranoid about these things. There are so many operators it’s too hard to remember all priorities by heart.

[marcelklehr]

/rebase

[marcelklehr]

It turns out, there was already code for this, but it didn't work.

[marcelklehr]

Citing @jancborchardt

Ok, then we go ahead as previously discussed and implemented in your PR, that is when Download is disabled, "Copy" is removed? Cause since we have this specific download restriction, the intention on the sharer’s side is clearly to prevent it spreading.

---

I can haz reviews?

[marcelklehr]

/rebase

[marcelklehr]

/compile

[marcelklehr]

/backport to stable26

[marcelklehr]

/backport to stable25

[backportbot-nextcloud]

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[backportbot-nextcloud]

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[marcelklehr]

/backport af66537 to stable25

[marcelklehr]

/backport af66537 to stable26

[solracsf]

/backport to stable27

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin/stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport