Uh oh!
There was an error while loading. Please reload this page.
Conversation
susnux
commented
Apr 18, 2023
ContributorAuthor
/backport to stable25 |
susnux
requested review from
a team, Pytal and skjnldsv
and removed request for
a teamApril 18, 2023 21:45
szaimen
reviewed
Apr 18, 2023
| .files-filestable tbody tr.externalErroredRow { | ||
| background-color: #F2DEDE; | ||
| /* TODO: As soon as firefox supports it: color-mix(in srgb, var(--color-error) 15%, var(--color-main-background)) */ | ||
| background-color: #f002; |
Contributor
There was a problem hiding this comment.
how would that look in light mode?
ContributorAuthor
There was a problem hiding this comment.
Bright color theme:
| before | after |
|---|---|
 |  |
szaimen
approved these changes
Apr 18, 2023
szaimen
left a comment
Contributor
There was a problem hiding this comment.
looks fine from the screenshots
skjnldsv
requested changes
Apr 19, 2023
Uh oh!
There was an error while loading. Please reload this page.
… should respect color theme Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Pytal
approved these changes
Apr 19, 2023
skjnldsv
approved these changes
Apr 20, 2023
szaimen
commented
Apr 20, 2023
Contributor
/backport to stable26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently if a external device has errors the background color of the files entry is hard coded, which will be unreadable on dark color mode.
To fix this I just overlay the background with semi transparent red color.
Screenshots
Checklist