Skip to content

fix(files_sharing): tab shares title and creation sort - #37878

Merged
skjnldsv merged 1 commit into
nextcloud:masterfrom
2lar:sortingfixbranch
Aug 7, 2024
Merged

fix(files_sharing): tab shares title and creation sort#37878
skjnldsv merged 1 commit into
nextcloud:masterfrom
2lar:sortingfixbranch

Conversation

@2lar

@2lar2lar commented Apr 21, 2023

Copy link
Copy Markdown

This is to fix sorting and branching.
based on issue: 36906
fix#36906

@szaimenszaimen added this to the Nextcloud 27 milestone Apr 22, 2023
@szaimenszaimen added the 3. to review Waiting for reviews label Apr 22, 2023
@szaimen
szaimen requested review from Pytal and artongeApril 22, 2023 16:36
@artonge

Copy link
Copy Markdown
Collaborator

@2lar Can you fix the linting issue first? npm run lint:fix should be enough.

This was referenced May 3, 2023
@blizzzblizzz mentioned this pull request May 17, 2023
@blizzzblizzz modified the milestones: Nextcloud 27, Nextcloud 28May 23, 2023
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@skjnldsv
skjnldsvforce-pushed the sortingfixbranch branch 2 times, most recently from 91f35cb to 2aa2822CompareFebruary 23, 2024 14:37
@skjnldsv
skjnldsv requested review from a team and sorbaugh and removed request for a teamFebruary 23, 2024 14:38
@skjnldsv
skjnldsv requested review from susnux and removed request for sorbaughFebruary 27, 2024 15:50
@AltahrimAltahrim mentioned this pull request Mar 12, 2024
@Altahrim

Copy link
Copy Markdown
Collaborator

@2lar Can you rebase and reword your commit using conventional commit please?
I guess you can squash in one commit

This was referenced Mar 14, 2024
@AltahrimAltahrim mentioned this pull request Mar 25, 2024
@Altahrim

Copy link
Copy Markdown
Collaborator

Rebased with one commit instead of two

@AltahrimAltahrim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 26, 2024
@susnux

Copy link
Copy Markdown
Contributor

/compile

@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
81 tasks
This was referenced Apr 4, 2024
@blizzzblizzz modified the milestones: Nextcloud 29, Nextcloud 30Apr 8, 2024
@joshtrichardsjoshtrichards changed the title Fixing the title and creation sortfix(files_sharing): tab shares title and creation sortMay 27, 2024
This was referenced Jul 30, 2024
@AltahrimAltahrim mentioned this pull request Aug 5, 2024
@AltahrimAltahrim mentioned this pull request Aug 7, 2024
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@skjnldsv
skjnldsv merged commit 3da69fc into nextcloud:masterAug 7, 2024
@welcome

welcomeBot commented Aug 7, 2024

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort shares by title and then creation date

7 participants

@2lar@artonge@Altahrim@susnux@skjnldsv@blizzz@szaimen