Skip to content

[stable26] Bump @nextcloud/vue from 7.8.0 to 7.10.0 - #37910

Merged
skjnldsv merged 1 commit into
stable26from
backport/37804/stable26
Apr 25, 2023
Merged

[stable26] Bump @nextcloud/vue from 7.8.0 to 7.10.0#37910
skjnldsv merged 1 commit into
stable26from
backport/37804/stable26

Conversation

@Pytal

Copy link
Copy Markdown
Member

Summary

Backport #37804

Checklist

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@PytalPytal added 3. to review Waiting for reviews dependencies labels Apr 24, 2023
@PytalPytal added this to the Nextcloud 26.0.2 milestone Apr 24, 2023
@PytalPytal self-assigned this Apr 24, 2023
@PytalPytal mentioned this pull request Apr 24, 2023
4 tasks
@skjnldsv
skjnldsv merged commit c263b15 into stable26Apr 25, 2023
@skjnldsv
skjnldsv deleted the backport/37804/stable26 branch April 25, 2023 07:05
@nickvergessen

Copy link
Copy Markdown
Member

Since this is merged, the right sidebar has no tab headers anymore on the files app:

$ git bisect good
9dc8e75bf2b1302d954aa7a77916372488b5fa32 is the first bad commit
commit 9dc8e75bf2b1302d954aa7a77916372488b5fa32
Author: Christopher Ng <chrng8@gmail.com>
Date: Mon Apr 24 16:14:15 2023 -0700
Bump @nextcloud/vue from 7.8.0 to 7.10.0
Signed-off-by: Christopher Ng <chrng8@gmail.com>
dist/core-common.js | Bin 15071827 -> 15173921 bytes
dist/core-common.js.map | Bin 30132375 -> 30462285 bytes
package-lock.json | 311 ++++++++++++++++++++++++++++++++++++++++++------
package.json | 2 +-
4 files changed, 275 insertions(+), 38 deletions(-)

Console is glowing red:

TypeError: e is null
VueJS 3
renderIcon NcAppSidebarTab.js:2
B NcAppSidebar.js:2
Xe VueJS
B NcAppSidebar.js:2
VueJS 14
i Sidebar.vue:435
d runtime.js:24
t runtime.js:267
T runtime.js:85
E LegacyView.vue:19
s LegacyView.vue:19
promise callback*E LegacyView.vue:19
s LegacyView.vue:19
P LegacyView.vue:19
P LegacyView.vue:19
open Sidebar.vue:425
_updateDetailsView filelist.js:709
actionHandler filelist.js:588
action fileactions.js:136
_onClickFile filelist.js:934
Underscore 3
jQuery 10
initialize filelist.js:386
FileList filelist.js:32
initialize app.js:83
<anonymous> app.js:400
Underscore 5
<anonymous> app.js:399
EventListener.handleEvent* app.js:396
vue.runtime.esm.js:3018:57

grafik

Only happens when "legacy sidebar" apps are enable, e.g. the default shipped app activity

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsdependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Pytal@nickvergessen@skjnldsv@szaimen