Skip to content

feat: Reword login form disabled warning #37949 - #37953

Merged
skjnldsv merged 2 commits into
nextcloud:masterfrom
moan0s:reword-disabled-login-form
Mar 19, 2024
Merged

feat: Reword login form disabled warning #37949#37953
skjnldsv merged 2 commits into
nextcloud:masterfrom
moan0s:reword-disabled-login-form

Conversation

@moan0s

@moan0smoan0s commented Apr 27, 2023•
edited by susnux
Loading

Copy link
Copy Markdown
Contributor

Summary

Rewords & restyles the warning used when the nextcloud login form is disabled

TODO

  • Decide if warning should be removed (this PR) or if the text should be replaced

Checklist

@szaimenszaimen added the 3. to review Waiting for reviews label Apr 27, 2023
@szaimenszaimen added this to the Nextcloud 27 milestone Apr 27, 2023
szaimen
szaimen approved these changes Apr 27, 2023
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is preferred by me over #37952. Just one small suggestion, see below.

Comment threadcore/src/views/Login.vue Outdated
@szaimen
szaimen requested review from a team, Pytal, artonge and skjnldsv and removed request for a teamApril 27, 2023 13:43
@szaimen

szaimen commented Apr 27, 2023

Copy link
Copy Markdown
Contributor

@moan0s please rebase this branch from master, run npm ci and npm run build and commit the changed files here. Then we can merge this. Thanks a lot! :)

@szaimen
szaimen enabled auto-merge April 27, 2023 14:06
auto-merge was automatically disabled April 27, 2023 14:07

Head branch was pushed to by a user without write access

@moan0s

moan0s commented Apr 27, 2023

Copy link
Copy Markdown
ContributorAuthor

I hope I did the rebase correctly, files should be okay

nimishavijay
nimishavijay reviewed Apr 27, 2023
View reviewed changes

@nimishavijaynimishavijay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, already a good improvement! left a comment with some slight changes in wording :)

Comment threadcore/src/views/Login.vue
@moan0smoan0s mentioned this pull request Apr 30, 2023
Closed
@skjnldsvskjnldsv mentioned this pull request May 3, 2023
Merged
@moan0smoan0s mentioned this pull request May 8, 2023
Merged
This was referenced May 9, 2023
Closed
Merged
@szaimenszaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 16, 2023
@blizzzblizzz mentioned this pull request May 17, 2023
Merged
szaimen
szaimen previously requested changes May 19, 2023
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a new Nextcloud vue 8.x version now to get released, updated here in server. Then we can rebase this branch and afterwards include the change here.

szaimen
szaimen reviewed May 19, 2023
View reviewed changes
Comment threadapps/files/js/app.js Outdated
szaimen
szaimen reviewed May 19, 2023
View reviewed changes
Comment threadcore/src/views/Login.vue Outdated
@blizzzblizzz modified the milestones: Nextcloud 27, Nextcloud 28May 23, 2023
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@timonegk

timonegk commented Jan 26, 2024

Copy link
Copy Markdown

I would also approve this change, any chance of merging it in the near future?

This was referenced Mar 12, 2024
Merged
Merged
@susnux
susnuxforce-pushed the reword-disabled-login-form branch from b9a2e28 to abbd844CompareMarch 17, 2024 18:56
@susnux
susnux dismissed szaimen’s stale reviewMarch 17, 2024 18:57

nextcloud-vue was updated

@susnuxsusnux added bug design Design, UI, UX, etc. 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Mar 17, 2024
@susnux
susnuxforce-pushed the reword-disabled-login-form branch from abbd844 to 654a2e6CompareMarch 17, 2024 19:10
moan0sand others added 2 commits March 17, 2024 20:22
@moan0s@szaimen@susnux
feat: Reword login form disabled warningnextcloud#37949
a6ce590
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Julian-Samuel Gebühr <julian-samuel@gebuehr.net>
@moan0s@susnux
chore: Add changed binaries
d397dd6
Signed-off-by: Julian-Samuel Gebühr <julian-samuel@gebuehr.net>
@susnux
susnuxforce-pushed the reword-disabled-login-form branch from 654a2e6 to d397dd6CompareMarch 17, 2024 19:24
@susnux

susnux commented Mar 17, 2024

Copy link
Copy Markdown
Contributor

Rebased - but I think drone does not work on forks?

@AltahrimAltahrim mentioned this pull request Mar 18, 2024
Merged
@skjnldsv
skjnldsv merged commit d9e1350 into nextcloud:masterMar 19, 2024
@welcome

welcomeBot commented Mar 19, 2024

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@szaimenszaimenszaimen left review comments
@nimishavijaynimishavijaynimishavijay left review comments
@skjnldsvskjnldsvskjnldsv approved these changes
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@artongeartongeAwaiting requested review from artongeartonge is a code owner automatically assigned from nextcloud/server-frontend
@PytalPytalAwaiting requested review from PytalPytal is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugdesignDesign, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

Improve or remove warning when hiding native login form

8 participants

@moan0s@szaimen@timonegk@susnux@jancborchardt@skjnldsv@nimishavijay@blizzz