Skip to content

Do not allow to toggle between password and text in sharing - #37954

Merged
artonge merged 1 commit into
masterfrom
artonge/fix/do_not_allow_to_show_pwd_in_sharing
May 10, 2023
Merged

Do not allow to toggle between password and text in sharing#37954
artonge merged 1 commit into
masterfrom
artonge/fix/do_not_allow_to_show_pwd_in_sharing

Conversation

@artonge

@artongeartonge commented Apr 27, 2023

Copy link
Copy Markdown
Collaborator

@artongeartonge added this to the Nextcloud 27 milestone Apr 27, 2023
@artonge
artonge requested a review from a teamApril 27, 2023 13:36
@artongeartonge self-assigned this Apr 27, 2023
@artonge
artonge requested review from Pytal, skjnldsv and szaimen and removed request for a teamApril 27, 2023 13:36
@szaimen

Copy link
Copy Markdown
Contributor

Since this needs a vue lib update, lets convert it into a draft...

@szaimen
szaimen marked this pull request as draft April 27, 2023 13:38
This was referenced May 3, 2023
@artonge

Copy link
Copy Markdown
CollaboratorAuthor

/rebase

@artonge
artonge marked this pull request as ready for review May 9, 2023 09:40
@artonge

Copy link
Copy Markdown
CollaboratorAuthor

/rebase

@artonge
artongeforce-pushed the artonge/fix/do_not_allow_to_show_pwd_in_sharing branch 2 times, most recently from 62e8117 to 3bd2884CompareMay 9, 2023 15:23
@artonge
artonge enabled auto-merge May 9, 2023 15:24
This does not makes sense as we do not have the clear text value.
Signed-off-by: Louis Chemineau <louis@chmn.me>
@nextcloud-command
nextcloud-commandforce-pushed the artonge/fix/do_not_allow_to_show_pwd_in_sharing branch from 3bd2884 to 12fd72dCompareMay 9, 2023 15:37
@artonge
artongeforce-pushed the artonge/fix/do_not_allow_to_show_pwd_in_sharing branch from 12fd72d to 6faf8b8CompareMay 9, 2023 15:41
@artonge

Copy link
Copy Markdown
CollaboratorAuthor

CI failure unrelated

@artonge
artonge disabled auto-merge May 10, 2023 08:23
@artonge
artonge merged commit 5993a4b into masterMay 10, 2023
@artonge
artonge deleted the artonge/fix/do_not_allow_to_show_pwd_in_sharing branch May 10, 2023 08:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@artonge@szaimen@skjnldsv@Pytal