Skip to content

do not fail if size metadata for an image fail - #38011

Closed
mgallien wants to merge 1 commit into
masterfrom
doNotFailWhenGetImageSizeMetadata
Closed

do not fail if size metadata for an image fail#38011
mgallien wants to merge 1 commit into
masterfrom
doNotFailWhenGetImageSizeMetadata

Conversation

@mgallien

@mgallienmgallien commented May 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

some images may trigger an exception when trying to get their size

Signed-off-by: Matthieu Gallien matthieu_gallien@yahoo.fr

fix for a blocking exception when running occ files:scan --generate-metadata for some images

Checklist

@mgallien
mgallien requested a review from a teamMay 1, 2023 18:49
@mgallien
do not fail if size metadata for an image fail
9e5521f
some images may trigger an exception when trying to get their size
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
@mgallien
mgallienforce-pushed the doNotFailWhenGetImageSizeMetadata branch from 8dd1da6 to 9e5521fCompareMay 1, 2023 18:50
@szaimenszaimen added the 3. to review Waiting for reviews label May 1, 2023
@szaimenszaimen added this to the Nextcloud 27 milestone May 1, 2023
@Pytal
Pytal requested review from a team, ArtificialOwl, come-nc and icewind1991 and removed request for a teamMay 1, 2023 22:45
@szaimen

szaimen commented May 2, 2023

Copy link
Copy Markdown
Contributor

Isnt #37944 the better approach?

kesselb
kesselb reviewed May 2, 2023
View reviewed changes
Comment threadlib/private/Metadata/Provider/ExifProvider.php
$sizeResult = getimagesizefromstring($file->getContent());
try {
$sizeResult = getimagesizefromstring($file->getContent());
} catch (\Exception $ex) {

@kesselbkesselbMay 2, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} catch (\Exception$ex) {
} catch (\TypeError$ex) {

As per php/php-src@b9171d8

@kesselb

kesselb commented May 2, 2023

Copy link
Copy Markdown
Contributor

Isnt #37944 the better approach?

Both make sense. The execute method has a proper error handling already. PHP 8 behaves different and throws an exception, but returned false for earlier versions.

come-nc
come-nc requested changes May 2, 2023
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not catch TypeError like this

@come-nc

come-nc commented May 2, 2023

Copy link
Copy Markdown
Contributor

@mgallien What is the trace of the error you are trying to fix?

@skjnldsvskjnldsv mentioned this pull request May 3, 2023
Merged
@mgallien

mgallien commented May 4, 2023

Copy link
Copy Markdown
ContributorAuthor

@come-nc see

Exception during scan: getimagesizefromstring(): Error reading from !
#0 [internal function]: OCA\Files\Command\Scan->exceptionErrorHandler()
#1 /var/www/nextcloud/lib/private/Metadata/Provider/ExifProvider.php(71): getimagesizefromstring()
#2 /var/www/nextcloud/lib/private/Metadata/MetadataManager.php(68): OC\Metadata\Provider\ExifProvider->execute()
#3 /var/www/nextcloud/apps/files/lib/Command/Scan.php(138): OC\Metadata\MetadataManager->generateMetadata()
#4 [internal function]: OCA\Files\Command\Scan->OCA\Files\Command\{closure}()
#5 /var/www/nextcloud/lib/private/Hooks/EmitterTrait.php(105): call_user_func_array()
#6 /var/www/nextcloud/lib/private/Hooks/PublicEmitter.php(40): OC\Hooks\BasicEmitter->emit()
#7 /var/www/nextcloud/lib/private/Files/Utils/Scanner.php(131): OC\Hooks\PublicEmitter->emit()
#8 [internal function]: OC\Files\Utils\Scanner->OC\Files\Utils\{closure}()
#9 /var/www/nextcloud/lib/private/Hooks/EmitterTrait.php(105): call_user_func_array()
#10 /var/www/nextcloud/lib/private/Files/Cache/Scanner.php(168): OC\Hooks\BasicEmitter->emit()
#11 /var/www/nextcloud/lib/private/Files/Cache/Scanner.php(436): OC\Files\Cache\Scanner->scanFile()
#12 /var/www/nextcloud/lib/private/Files/Cache/Scanner.php(382): OC\Files\Cache\Scanner->handleChildren()
#13 /var/www/nextcloud/lib/private/Files/Cache/Scanner.php(385): OC\Files\Cache\Scanner->scanChildren()
#14 /var/www/nextcloud/lib/private/Files/Cache/Scanner.php(385): OC\Files\Cache\Scanner->scanChildren()
#15 /var/www/nextcloud/lib/private/Files/Cache/Scanner.php(385): OC\Files\Cache\Scanner->scanChildren()
#16 /var/www/nextcloud/lib/private/Files/Cache/Scanner.php(333): OC\Files\Cache\Scanner->scanChildren()
#17 /var/www/nextcloud/lib/private/Files/Utils/Scanner.php(256): OC\Files\Cache\Scanner->scan()
#18 /var/www/nextcloud/apps/files/lib/Command/Scan.php(161): OC\Files\Utils\Scanner->scan()
#19 /var/www/nextcloud/apps/files/lib/Command/Scan.php(217): OCA\Files\Command\Scan->scanFiles()
#20 /var/www/nextcloud/apps/recognize/vendor/symfony/console/Command/Command.php(298): OCA\Files\Command\Scan->execute()
#21 /var/www/nextcloud/core/Command/Base.php(177): Symfony\Component\Console\Command\Command->run()
#22 /var/www/nextcloud/apps/recognize/vendor/symfony/console/Application.php(1040): OC\Core\Command\Base->run()
#23 /var/www/nextcloud/apps/recognize/vendor/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand()
#24 /var/www/nextcloud/apps/recognize/vendor/symfony/console/Application.php(171): Symfony\Component\Console\Application->doRun()
#25 /var/www/nextcloud/lib/private/Console/Application.php(215): Symfony\Component\Console\Application->run()
#26 /var/www/nextcloud/console.php(100): OC\Console\Application->run()
#27 /var/www/nextcloud/occ(11): require_once('...')
#28 {main}

@come-nc

come-nc commented May 4, 2023

Copy link
Copy Markdown
Contributor

@mgallien This is fixed by #37944

@mgallien

mgallien commented May 4, 2023

Copy link
Copy Markdown
ContributorAuthor

@come-nc so let's close #38011

@mgallienmgallien closed this May 4, 2023
@mgallien
mgallien deleted the doNotFailWhenGetImageSizeMetadata branch May 5, 2023 07:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nccome-nccome-nc requested changes
@kesselbkesselbkesselb approved these changes
@JuliaKirschenheuterJuliaKirschenheuterJuliaKirschenheuter approved these changes
@solracsfsolracsfsolracsf approved these changes
@PytalPytalPytal approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

7 participants

@mgallien@szaimen@kesselb@come-nc@JuliaKirschenheuter@solracsf@Pytal