Skip to content

fix: add workaround for oci and limit queries - #38016

Merged
kesselb merged 1 commit into
masterfrom
oracle-limit-workaround
May 3, 2023
Merged

fix: add workaround for oci and limit queries#38016
kesselb merged 1 commit into
masterfrom
oracle-limit-workaround

Conversation

@kesselb

@kesselbkesselb commented May 2, 2023

Copy link
Copy Markdown
Contributor

Summary

DBAL uses a helper column "doctrine_rownum" for oci queries with limit and offset1.
The column is also present in the query result and qbmapper tries to set it for the entity.

1) OCA\EndToEndEncryption\Tests\Unit\Db\LockMapperTest::testFindAllLocksOlderThan
BadFunctionCallException: dOCTRINEROWNUM is not a valid attribute
/home/runner/work/end_to_end_encryption/end_to_end_encryption/lib/public/AppFramework/Db/Entity.php:138
/home/runner/work/end_to_end_encryption/end_to_end_encryption/lib/public/AppFramework/Db/Entity.php:167
/home/runner/work/end_to_end_encryption/end_to_end_encryption/lib/public/AppFramework/Db/Entity.php:75
/home/runner/work/end_to_end_encryption/end_to_end_encryption/lib/public/AppFramework/Db/QBMapper.php:320
/home/runner/work/end_to_end_encryption/end_to_end_encryption/lib/public/AppFramework/Db/QBMapper.php:338
/home/runner/work/end_to_end_encryption/end_to_end_encryption/apps/end_to_end_encryption/lib/Db/LockMapper.php:70
/home/runner/work/end_to_end_encryption/end_to_end_encryption/apps/end_to_end_encryption/tests/Unit/Db/LockMapperTest.php:110

TODO

  • CI

Checklist

Footnotes

  1. https://github.com/doctrine/dbal/pull/2509

DBAL uses a helper column "doctrine_rownum" for top-n queries
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the oracle-limit-workaround branch from 1ca5c3f to eecdb62CompareMay 2, 2023 12:26
@kesselbkesselb self-assigned this May 2, 2023
@kesselbkesselb added 3. to review Waiting for reviews bug labels May 2, 2023
@kesselb
kesselb requested review from ChristophWurst and removed request for ChristophWurstMay 2, 2023 12:28
@kesselb
kesselb marked this pull request as ready for review May 2, 2023 12:28

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲 👍

@kesselb
kesselb requested a review from nickvergessenMay 2, 2023 12:58

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprise pikachu

@kesselb
kesselb merged commit db73534 into masterMay 3, 2023
@kesselb
kesselb deleted the oracle-limit-workaround branch May 3, 2023 21:07
@kesselb

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kesselb@nickvergessen@ChristophWurst