Uh oh!
There was an error while loading. Please reload this page.
[stable26] Add commands for basic file actions - #38250
Merged
Merged
Conversation
There was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Merged
blizzz
commented
May 17, 2023
Member
backport incomplete |
Merged
blizzz
commented
Jun 15, 2023
Member
moving to 26.0.4 |
Merged
blizzz
commented
Jul 13, 2023
Member
moving to 26.0.5 |
Merged
blizzz
commented
Aug 3, 2023
Member
moving to 26.0.6 If there are no updates in any form until building 26.0.6, I will close this PR. |
Merged
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
… as argument instead of option Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
backport/37971/stable26
branch
from
September 6, 2023 12:41
985fbc1 to
2f662bfCompare| return 1; | ||
| } | ||
| $source = $node->fopen('r'); | ||
| if (!$source) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
| return 1; | ||
| } | ||
| $source = $node->fopen('r'); | ||
| if (!$source) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
| } | ||
| if ($node instanceof File) { | ||
| $target = $node->fopen('w'); | ||
| if (!$target) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
| } | ||
| if ($node instanceof File) { | ||
| $target = $node->fopen('w'); | ||
| if (!$target) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
icewind1991
marked this pull request as ready for review
September 6, 2023 12:50
blizzz
commented
Sep 7, 2023
Member
moving to 26.0.7 due to missing reviews, but thanks @icewind1991 for bringing this back to life |
come-nc
approved these changes
Sep 7, 2023
Merged
blizzz
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #37971