Files : Left panel dropdown improvement for NC 25

[Jerome-Herbinet]

Respawn of #38217 (which is now closed)

Before :

before.2.webm

After :

after.2.webm

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[szaimen]

@Jerome-Herbinet do you have some screenshots?

[Jerome-Herbinet]

@Jerome-Herbinet do you have some screenshots?

Could you check the previous PR that contained the same commits #38217 ?

[szaimen]

Can you please add them to the PRs description?

[Jerome-Herbinet]

Can you please add them to the PRs description?

Done :-)

[szaimen]

LGTM but didnt test

btw, why is the dropdown button of shares not shown all the time?

[Jerome-Herbinet]

Can somebody test the Mail app with this PR ?
@GretaD warned me about some side-effects there (see equivalent PR for NC 26 nextcloud-libraries/nextcloud-vue#4103).

[szaimen]

Can somebody test the Mail app with this PR ?

Mail is using the vue components so this specific PR should not change the behaviour there...

[blizzz]

moving to 25.0.8

[blizzz]

Why is it open against stable25 in first place?

[szaimen]

Why is it open against stable25 in first place?

Because starting with 26 the files app uses the vue component. 25 still has the old aidebar

[jancborchardt]

Very nice improvement to make it more obvious @Jerome-Herbinet!

One thing I also noted in the other PR: The triangle pointing to the right is confusing, it would be expected to have a triangle pointing down when in closed state, indicating more things open downwards. :)

When open, the arrow should still point down too. Then it would behave exactly like a standard HTML select element.

[Jerome-Herbinet]

Very nice improvement to make it more obvious @Jerome-Herbinet!

One thing I also noted in the other PR: The triangle pointing to the right is confusing, it would be expected to have a triangle pointing down when in closed state, indicating more things open downwards. :)

When open, the arrow should still point down too. Then it would behave exactly like a standard HTML select element.

It should be OK with the commit I just made @jancborchardt ; could you test it ?
I have one question ; when I do a "npm run sass", I obtain a large amount of modified files ; is it more than necessary ? Can I commit and push all of them ?

[Jerome-Herbinet]

Very nice improvement to make it more obvious @Jerome-Herbinet!
One thing I also noted in the other PR: The triangle pointing to the right is confusing, it would be expected to have a triangle pointing down when in closed state, indicating more things open downwards. :)
When open, the arrow should still point down too. Then it would behave exactly like a standard HTML select element.

It should be OK with the commit I just made @jancborchardt ; could you test it ? I have one question ; when I do a "npm run sass", I obtain a large amount of modified files ; is it more than necessary ? Can I commit and push all of them ?

... and concerning the other PR, I'll do a complementary PR a little later because #38338 has already been merged.

[blizzz]

moving to 25.0.9

[blizzz]

What's the outlook here?

[blizzz]

moving to 25.0.10

[blizzz]

moving to 25.0.11

[jancborchardt]

@Jerome-Herbinet what’s the current state here? :) If you need help with the frontend/compilation, maybe @juliushaertl@susnux can advise?

[susnux]

@Jerome-Herbinet
I think you just need to sign the last commit (or squash them and ensure the resulting one is signed).
Build the assets (npm ci && npm run build) (and commit).

Otherwise the PR seems to be fine.

[Jerome-Herbinet]

New PR #39779