Uh oh!
There was an error while loading. Please reload this page.
38340 fix add group broken - #38344
Merged
Merged
Conversation
nfebeforce-pushed
the
38340-fix-add-group-broken
branch
3 times, most recently
from
May 17, 2023 13:18
29dd7f6 to
7f4ce58Comparenfebe
requested review from
a team, ArtificialOwl, artonge, come-nc, icewind1991 and susnux
and removed request for
a teamMay 17, 2023 13:21
nfebeforce-pushed
the
38340-fix-add-group-broken
branch
from
May 17, 2023 13:23
7f4ce58 to
40cff7bCompareartonge
approved these changes
May 17, 2023
artonge
commented
May 17, 2023
Collaborator
Sad that linting is not able to warn us on this kind of mistake |
nfebeforce-pushed
the
38340-fix-add-group-broken
branch
from
May 17, 2023 13:25
40cff7b to
3421ff6Comparesusnux
commented
May 17, 2023
Contributor
It could if we would use TS and nextcloud-vue would provide type information 😉 |
susnux
approved these changes
May 17, 2023
szaimen
commented
May 17, 2023
Contributor
/backport to stable27 |
nfebe
commented
May 18, 2023
ContributorAuthor
/compile amend / |
nextcloud-commandforce-pushed
the
38340-fix-add-group-broken
branch
from
May 18, 2023 07:17
3421ff6 to
e9e9879Comparenfebeforce-pushed
the
38340-fix-add-group-broken
branch
from
May 18, 2023 07:27
e9e9879 to
9c7606dComparenfebe
commented
May 18, 2023
ContributorAuthor
/compile amend / |
1ee8fba broke the addgroup functionality by not updating the event to reflect the one in https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcAppNavigationNewItem/NcAppNavigationNewItem.vueResolves : #38340 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
38340-fix-add-group-broken
branch
from
May 18, 2023 07:49
9c7606d to
ec91547Compare1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1ee8fbaad1eea6544b21059f65efe12a9e601956 broke the addgroup functionality by not updating the event to reflect the one in
https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcAppNavigationNewItem/NcAppNavigationNewItem.vue
Resolves : #38340