Uh oh!
There was an error while loading. Please reload this page.
[stable27] Show pending popover menu when password is enabled by default - #38395
Merged
Conversation
nickvergessen
approved these changes
May 23, 2023
Pytal
approved these changes
May 23, 2023
Merged
Merged
blizzz
commented
Jul 10, 2023
Member
/compile amend / |
nextcloud-commandforce-pushed
the
backport/38164/stable27
branch
from
July 10, 2023 17:32
edacc26 to
90ef83bCompareblizzz
commented
Jul 11, 2023
Member
still conflicts :-/ |
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When "Enforce password protection" is enabled in the sharing settings a popover menu is shown to set a password before the share is created. On the other hand, when "Always ask for a password" was enabled in the sharing settings and a new link share was created the share was immediately created with a default password; the user was not able to specify a password (nor create the share without password). The component template already provided the needed elements to also ask for the password without enforcing it, but the popover menu was not shown due to "enableLinkPasswordByDefault" being missing in "if" conditions. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliuforce-pushed
the
backport/38164/stable27
branch
2 times, most recently
from
July 13, 2023 06:17
8890427 to
03095bbComparedanxuliu
commented
Jul 13, 2023
Member
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
danxuliu
approved these changes
Jul 13, 2023
danxuliu
left a comment
Member
There was a problem hiding this comment.
Tested and works 👍
CI failure (psalm) is unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #38164