Uh oh!
There was an error while loading. Please reload this page.
don't always check if we need to setup the object store root - #38415
Merged
Conversation
icewind1991
requested review from
a team, ArtificialOwl, blizzz and nfebe
and removed request for
a teamMay 23, 2023 12:38
icewind1991force-pushed
the
object-store-init-root
branch
3 times, most recently
from
May 23, 2023 15:02
9e9dc14 to
2f05d0fCompareSigned-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
object-store-init-root
branch
from
May 23, 2023 15:44
2f05d0f to
cc0ad25Comparejuliusknorr
approved these changes
May 23, 2023
blizzz
approved these changes
May 24, 2023
icewind1991
commented
May 24, 2023
MemberAuthor
/backport to stable27 |
icewind1991
commented
May 24, 2023
MemberAuthor
/backport to stable26 |
icewind1991
commented
May 24, 2023
MemberAuthor
/backport to stable25 |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents having to check if the root is initialized every time we construct an object store.
Normally, the impact of this is fairly small, but when
objectstore.multibucket.preview-distributionis enbled, we always setup 256 object stores