fix(settings): Align user management table columns by ChristophWurst · Pull Request #38424 · nextcloud/server

ChristophWurst · 2023-05-23T16:27:19Z

Resolves the first regression in [BITV]: Bug User management table view regressions #38245

Summary

Before	After

TODO

Fix the regression

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

ChristophWurst · 2023-05-23T16:27:30Z

/backport to stable27

szaimen · 2023-05-23T17:28:55Z

@ChristophWurst before and after looks exactly the same?

ChristophWurst · 2023-05-23T17:55:46Z

No look how the groups header and the contents don't align before ;)

szaimen · 2023-05-23T18:17:47Z

No look how the groups header and the contents don't align before ;)

Ah I looked at the wrong place 😅

szaimen

LGTM but didnt test

JuliaKirschenheuter

unfortunately that doesn't work like this. please test with more columns

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

JuliaKirschenheuter · 2023-05-24T15:42:47Z

Initial problem seems to that display: grid should't be for #body-settings #app-content.user-list-grid .row. Solution could be to use display: flex for all rows inside a table.

But I still have some problems ;(

Alignment of columns
Styles for editing mode

JuliaKirschenheuter · 2023-05-24T15:47:12Z

I've also tried to replace grid column's width, but that haven't worked

Now all columns have the same width besides avatar column.

ChristophWurst · 2023-05-25T07:27:42Z

is it done?

JuliaKirschenheuter · 2023-05-25T07:53:12Z

is it done?

unfortunately not. do you have any ideas?

ChristophWurst · 2023-05-25T08:04:15Z

@AndyScherzinger this won't make it for RC2 apparently. Shall we revert #37870 instead and redo the restructuring cleanly for 28?

AndyScherzinger · 2023-05-25T08:46:20Z

Shall we revert #37870 instead and redo the restructuring cleanly for 28?

@ChristophWurst @JuliaKirschenheuter yes, let's do that then

JuliaKirschenheuter · 2023-05-25T09:56:22Z

#38458

JuliaKirschenheuter · 2023-05-25T11:32:07Z

@ChristophWurst please let this branch be alife for a bit

ChristophWurst · 2023-05-25T12:42:12Z

You can restore the branch at any time.

fix(settings): Align user management table columns
505d7de
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

ChristophWurst added bug 3. to review Waiting for reviews feature: users and groups regression labels May 23, 2023

ChristophWurst added this to the Nextcloud 28 milestone May 23, 2023

ChristophWurst requested review from a team, JuliaKirschenheuter, nfebe, susnux and szaimen and removed request for a teamMay 23, 2023 16:27

backportbot-nextcloudBot added the backport-request label May 23, 2023

szaimen approved these changes May 23, 2023
View reviewed changes

JuliaKirschenheuter requested changes May 24, 2023
View reviewed changes

Rework "grid" table rows to "flex" table rows
859f6af
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

JuliaKirschenheuter requested a review from Pytal May 24, 2023 15:30

JuliaKirschenheuter marked this pull request as draft May 24, 2023 15:30

JuliaKirschenheuter added 2 commits May 24, 2023 17:35

fixup! Rework "grid" table rows to "flex" table rows
c9498cd
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

fixup! Rework "grid" table rows to "flex" table rows
dbf5376
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

ChristophWurst added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 24, 2023

JuliaKirschenheuter assigned JuliaKirschenheuter and ChristophWurst May 25, 2023

JuliaKirschenheuter mentioned this pull request May 25, 2023
[BITV] 9.1.3.1e/8.1 - The user table represents a grid element and should be implemented as such. (1) #36921
Closed
2 tasks

JuliaKirschenheuter closed this May 25, 2023

JuliaKirschenheuter removed the 2. developing Work in progress label May 25, 2023

ChristophWurst deleted the fix/settings/user-management-table-alignment branch May 25, 2023 10:41

JuliaKirschenheuter restored the fix/settings/user-management-table-alignment branch May 25, 2023 11:31

ChristophWurst removed the backport-request label Dec 1, 2023

skjnldsv deleted the fix/settings/user-management-table-alignment branch March 14, 2024 07:50

skjnldsv removed this from the Nextcloud 28 milestone Aug 14, 2024

Uh oh!

Uh oh!

Conversation

ChristophWurst commented May 23, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

Checklist

Uh oh!

ChristophWurst commented May 23, 2023

Uh oh!

szaimen commented May 23, 2023

Uh oh!

ChristophWurst commented May 23, 2023

Uh oh!

szaimen commented May 23, 2023

Uh oh!

szaimen left a comment

Choose a reason for hiding this comment

Uh oh!

JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

Uh oh!

JuliaKirschenheuter commented May 24, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JuliaKirschenheuter commented May 24, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChristophWurst commented May 25, 2023

Uh oh!

JuliaKirschenheuter commented May 25, 2023

Uh oh!

ChristophWurst commented May 25, 2023

Uh oh!

AndyScherzinger commented May 25, 2023

Uh oh!

JuliaKirschenheuter commented May 25, 2023

Uh oh!

JuliaKirschenheuter commented May 25, 2023

Uh oh!

ChristophWurst commented May 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ChristophWurst commented May 23, 2023•
edited
Loading

JuliaKirschenheuter commented May 24, 2023•
edited
Loading

JuliaKirschenheuter commented May 24, 2023•
edited
Loading