Skip to content

fix(carddav): Don't show system address book cards to guests - #38448

Merged
blizzz merged 1 commit into
masterfrom
fix/carddav/no-sab-guest-users
May 25, 2023
Merged

fix(carddav): Don't show system address book cards to guests#38448
blizzz merged 1 commit into
masterfrom
fix/carddav/no-sab-guest-users

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented May 24, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Guests should not see other users in the system address book

TODO

Checklist

@ChristophWurstChristophWurst added this to the Nextcloud 28 milestone May 24, 2023
@ChristophWurstChristophWurst self-assigned this May 24, 2023
@ChristophWurstChristophWurst changed the title Fix/carddav/no sab guest usersfix(carddav): Don't show system address book cards to guestsMay 24, 2023
@ChristophWurstChristophWurst mentioned this pull request May 25, 2023
Merged
10 tasks
@ChristophWurst
ChristophWurstforce-pushed the fix/carddav/no-sab-guest-users branch from e750762 to 9955c0dCompareMay 25, 2023 10:06
@ChristophWurstChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 25, 2023
@ChristophWurst

ChristophWurst commented May 25, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@ChristophWurst
ChristophWurst marked this pull request as ready for review May 25, 2023 10:06
tcitworld
tcitworld reviewed May 25, 2023
View reviewed changes
Comment threadapps/dav/lib/CardDAV/SystemAddressbook.php
@ChristophWurst
fix(carddav): Don't show system address book cards to guests
e524631
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
ChristophWurstforce-pushed the fix/carddav/no-sab-guest-users branch from 9955c0d to e524631CompareMay 25, 2023 10:26
hamza221
hamza221 approved these changes May 25, 2023
View reviewed changes

@hamza221hamza221 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 25, 2023
@blizzz
blizzz enabled auto-merge May 25, 2023 13:55
@blizzz
blizzz merged commit cd5bd11 into masterMay 25, 2023
@blizzz
blizzz deleted the fix/carddav/no-sab-guest-users branch May 25, 2023 15:26
@ChristophWurst

ChristophWurst commented May 25, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@ChristophWurst

ChristophWurst commented May 25, 2023

Copy link
Copy Markdown
MemberAuthor

(bot is not very responsive today)

@blizzz

blizzz commented May 25, 2023

Copy link
Copy Markdown
Member

perhaps Manuel can help

@blizzzblizzz mentioned this pull request May 25, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tcitworldtcitworldtcitworld left review comments
@hamza221hamza221hamza221 approved these changes
@JohannesGGEJohannesGGEJohannesGGE approved these changes
@miaulalalamiaulalalaAwaiting requested review from miaulalala
@blizzzblizzzAwaiting requested review from blizzz
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@kesselbkesselbAwaiting requested review from kesselb

Assignees

@ChristophWurstChristophWurst

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: carddavRelated to CardDAV internalsfeature: davfeature: users and groups

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

7 participants

@ChristophWurst@blizzz@nickvergessen@tcitworld@hamza221@JohannesGGE@skjnldsv