fix(carddav): Make system contact phone number RFC compliant

[GretaD]

• Resolves: "OTHER phone" vs "Other email" contacts#3403

Summary

The RFC specs the allowed types for a TEL property:

server/apps/dav/lib/CardDAV/Converter.php

Line 92 in 1f2a9de

$vCard->add(newText($vCard, 'TEL', $property->getValue(), ['TYPE' => 'OTHER', 'X-NC-SCOPE' => $scope]));

. OTHER is invalid. This was a bad copy-paste from another prop.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[ChristophWurst]

Works but commit and PR title are really misleading

change it to fix(carddav): Make system contact phone number RFC compliant

We are not fixing the capitalization here. We are fixing an invalid TEL property in the system contact vcard.

[ChristophWurst]

/backport to stable27

[ChristophWurst]

@GretaD you have to amend to change the commit title

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin/stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[ChristophWurst]

/backport to stable27

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin/stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[ChristophWurst]

/backport to stable27