Skip to content

log failures to read certificates during listing - #38468

Merged
icewind1991 merged 1 commit into
masterfrom
log-cert-list-errors
May 31, 2023
Merged

log failures to read certificates during listing#38468
icewind1991 merged 1 commit into
masterfrom
log-cert-list-errors

Conversation

@icewind1991

Copy link
Copy Markdown
Member

And check that we could actually read the file

@icewind1991icewind1991 added the 3. to review Waiting for reviews label May 25, 2023
@icewind1991icewind1991 added this to the Nextcloud 28 milestone May 25, 2023
@icewind1991
icewind1991 requested review from a team, ArtificialOwl, blizzz and nfebe and removed request for a teamMay 25, 2023 15:04
Comment threadlib/private/Security/CertificateManager.php

@nfebenfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left an inline comment/question, otherwise it looks good. Thanks!

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the log-cert-list-errors branch from 825b658 to 223612bCompareMay 31, 2023 12:40
@icewind1991
icewind1991 merged commit 496a8d2 into masterMay 31, 2023
@icewind1991
icewind1991 deleted the log-cert-list-errors branch May 31, 2023 14:16
@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@kesselb@nfebe