Uh oh!
There was an error while loading. Please reload this page.
[stable26] Ungroup placeholder css rules - #38487
Merged
Merged
Conversation
susnuxforce-pushed
the
backport/37522/stable26
branch
from
May 30, 2023 10:08
f71f86d to
8e6e936Comparesusnux
requested review from
a team, Pytal, nfebe and szaimen
and removed request for
a teamMay 30, 2023 10:08
nfebe
approved these changes
May 30, 2023
nfebe
left a comment
Contributor
There was a problem hiding this comment.
CI is not happy yet though :)
susnuxforce-pushed
the
backport/37522/stable26
branch
from
May 30, 2023 17:49
8e6e936 to
a4f3dcfComparesusnux
commented
May 30, 2023
ContributorAuthor
CI errors are unrelated (there are no PHP code changes) |
…emoving all rules When rules are grouped using the comma operator and one selector is invalid / unknown then the whole group is invalidated[1]. In this case `::-ms-input-placeholder` is unknown to Firefox and Chrome, so the `::placeholder` rule is never applied. [1]: https://www.w3.org/TR/selectors-3/#grouping Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnuxforce-pushed
the
backport/37522/stable26
branch
from
June 7, 2023 12:31
dbb8ff7 to
672d44cComparesusnux
enabled auto-merge
June 7, 2023 12:31
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
placeholdercss rules to prevent browsers from removing all rules" #38437 for 26.0.3Summary
When rules are grouped using the comma operator and one selector is invalid / unknown then the whole group is invalidated[1]. In this case
::-ms-input-placeholderis unknown to Firefox and Chrome, so the::placeholderrule is never applied. [1]: https://www.w3.org/TR/selectors-3/#groupingChecklist