Uh oh!
There was an error while loading. Please reload this page.
emit an event when a message is logged - #38490
Merged
Merged
Conversation
icewind1991
requested review from
a team, ArtificialOwl, blizzz and nfebe
and removed request for
a teamMay 26, 2023 17:05
1 task
icewind1991
marked this pull request as ready for review
May 26, 2023 17:06
icewind1991force-pushed
the
log-dispatch-event
branch
4 times, most recently
from
June 5, 2023 15:36
3507df8 to
3d72315Compareicewind1991force-pushed
the
log-dispatch-event
branch
from
June 9, 2023 16:06
3d72315 to
d246eaaComparecome-nc
reviewed
Jun 12, 2023
come-nc
left a comment
Contributor
There was a problem hiding this comment.
Performance-wise, is that not too much overhead?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
icewind1991force-pushed
the
log-dispatch-event
branch
from
June 12, 2023 15:24
d246eaa to
6af1f8eCompareicewind1991
commented
Jun 12, 2023
MemberAuthor
From my understanding the event dispatcher is well optimized for the "no listeners" case. |
come-nc
approved these changes
Jun 13, 2023
nfebe
approved these changes
Jun 13, 2023
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
log-dispatch-event
branch
from
June 13, 2023 16:46
6af1f8e to
d9fa7b1Compareicewind1991
commented
Jun 14, 2023
MemberAuthor
/backport to stable27 |
icewind1991
commented
Jun 14, 2023
MemberAuthor
/backport to stable26 |
This was referenced Jun 14, 2023
ChristophWurst
commented
Jun 15, 2023
Member
New API -> docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow apps to do their own handling, notably this is emitted even if it would be normally filtered by log level
Needed for nextcloud/logreader#873