Uh oh!
There was an error while loading. Please reload this page.
[stable25] redis: use atomic operations everywhere - #38570
Closed
backportbot-nextcloud[bot] wants to merge 4 commits into
Closed
[stable25] redis: use atomic operations everywhere#38570backportbot-nextcloud[bot] wants to merge 4 commits into
backportbot-nextcloud[bot] wants to merge 4 commits into
Conversation
This removes a lot of acrobatics in the code and does each operation atomically using a lua script. This also reduces several round trips to the server, and the scripts are compiled and cached server-side. Notably, since all operations work only on a single key (except clear, which is broken anyway and shouldn't be used), they will continue to function and be atomic for Redis cluster. Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| return $result; | ||
| } | ||
| protected static function encodeValue(mixed $value): string { |
Check failure
Code scanning / Psalm
ReservedWord
| return is_int($value) ? (string) $value : json_encode($value); | ||
| } | ||
| protected static function decodeValue(string $value): mixed { |
Check failure
Code scanning / Psalm
ReservedWord
ChristophWurst
commented
Jun 1, 2023
Member
There is a lot missing in the diff :s |
Merged
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Update Redis.php Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix typo Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix self:: calls Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix CI Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsfforce-pushed
the
backport/38539/stable25
branch
from
June 22, 2023 05:38
0ff5224 to
8a6c2d3Compare Merged
blizzz
commented
Jul 10, 2023
Member
Is someone working on this? |
blizzz
commented
Jul 13, 2023
Member
moving to 25.0.10 |
Merged
blizzz
commented
Aug 3, 2023
Member
moving to 25.0.11 |
Merged
blizzz
commented
Sep 7, 2023
Member
moving to 25.0.12 If there an no updates to this PR, I am going to close it if it does not meet next release. |
Merged
blizzz
commented
Oct 12, 2023
Member
closing as it's not ready and 25 is being sunsetted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #38539