feat(HTTPClient): Provide wrapped access to Guzzle's asyncRequest()

[nickvergessen]

• Resolves: Exposing GuzzleHttp\Client::asyncRequest() #35959

Summary

Following the approach discussed in #35959 to allow making async requests, e.g. required for interaction with webhooks in a non-blocking way.

Sample usage

$client = $this->clientService->newClient();
$promise = $client->postAsync($webhook->getUrl(), $data);
$promise->then(function (IResponse$response) use ($webhook) {
if ($response->getStatusCode() !== Http::STATUS_OK && $response->getStatusCode() !== Http::STATUS_ACCEPTED) {
$this->logger->error('Webhook responded with unexpected status code, increasing error count');
}
$this->logger->debug('Webhook successfully executed');
}, function (RequestException$exception) {
$this->logger->error('Webhook error occurred, increasing error count', ['exception' => $exception]);
});

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nickvergessen]

Tests and docs will follow after my vacation.
But could get the first round of reviews on the approach in the meantime 😎

[ChristophWurst]

Looks good

[nickvergessen]

@come-nc@blizzz second review?

[come-nc]

What does that do?
And the wrapping around onRejected is even weirder as it seems to just pass on the call?

[come-nc]

Oh it wraps the internal $response object in something from OCP, right? Then I get it, but I do not get the one for onRejected.

[nickvergessen]

yeah it's about only exposing OCP.
Same basically on the rejection, we are removing the Guzzle "type hint" and just require a \Exception eating closure instead of a GuzzleHttp\Exception\RequestException one.

[nickvergessen]

Rebased and squashed