Uh oh!
There was an error while loading. Please reload this page.
fix(weather_status): Pass address as param to OSM API - #38665
Merged
Conversation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
a team, ArtificialOwl, blizzz, icewind1991 and julien-nc
and removed request for
a teamJune 6, 2023 10:59
susnux
commented
Jun 6, 2023
ContributorAuthor
/backport to stable27 |
blizzz
approved these changes
Jun 8, 2023
tcitworld
commented
Aug 16, 2023
Member
This also fixes another issue caused by Nominatim changing their API, see osm-search/Nominatim#3134 and nextcloud/maps#1111 Can we backport to stable26 and 25? |
susnux
commented
Aug 16, 2023
ContributorAuthor
/backport to stable26 |
susnux
commented
Aug 16, 2023
ContributorAuthor
/backport to stable25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For some addresses the location can not be fetched although the address is correct.
For example
Bruxelleswill fetch the forecast initially but when adding it as a favorite and selecting it, it does not work because the address is saved asVille de Bruxelles - Stad Brussel, België / Belgique / Belgienwhich contains the/character.This is simply solved by passing the address as the query parameter (as the OSM documentation states).
Screenshots (screen cast gifs)
Checklist