Skip to content

Wordings : Enhancement of background and UI color change thanks to better title and description - #38670

Merged
skjnldsv merged 1 commit into
masterfrom
Jerome-Herbinet-ui-colour-concept
May 2, 2024
Merged

Wordings : Enhancement of background and UI color change thanks to better title and description#38670
skjnldsv merged 1 commit into
masterfrom
Jerome-Herbinet-ui-colour-concept

Conversation

@Jerome-Herbinet

@Jerome-HerbinetJerome-Herbinet commented Jun 6, 2023

Copy link
Copy Markdown
Member

Summary

Everything is in the PR's title and in the commit.

Checklist

skjnldsv
skjnldsv reviewed Jun 6, 2023
View reviewed changes
Comment threadapps/theming/src/UserThemes.vue Outdated
@Jerome-Herbinet
Jerome-Herbinetforce-pushed the Jerome-Herbinet-ui-colour-concept branch from 6e1e780 to d1198b4CompareJune 6, 2023 13:39
@Jerome-Herbinet

Jerome-Herbinet commented Jun 6, 2023

Copy link
Copy Markdown
MemberAuthor

Question :
Some other files than "dist/theming-personal-theming.js" and "dist/theming-personal-theming.js.map" have been generated by my first "npm run build", but haven't been regerated after by my others "npm run build". Is this normal ?

jancborchardt
jancborchardt requested changes Jun 8, 2023
View reviewed changes
Comment threadapps/theming/src/UserThemes.vue Outdated
Comment threadapps/theming/src/UserThemes.vue Outdated
jancborchardt
jancborchardt approved these changes Jun 8, 2023
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@Jerome-Herbinet
Jerome-Herbinetforce-pushed the Jerome-Herbinet-ui-colour-concept branch from f5ebedb to 0819284CompareJune 8, 2023 13:30
@solracsfsolracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@blizzzblizzz mentioned this pull request Nov 22, 2023
Merged
5 tasks
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@skjnldsv

skjnldsv commented Feb 28, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@Jerome-Herbinet can you rebase and solve the conflicts? :)
I'd like to merge this 🚀

@skjnldsvskjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Feb 28, 2024
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv
skjnldsvforce-pushed the Jerome-Herbinet-ui-colour-concept branch from 0819284 to cce2c93CompareMay 2, 2024 14:44
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish bug and removed 2. developing Work in progress stale Ticket or PR with no recent activity labels May 2, 2024
@skjnldsv
skjnldsvforce-pushed the Jerome-Herbinet-ui-colour-concept branch from cce2c93 to acf2ea3CompareMay 2, 2024 14:46
@skjnldsv
fix(theming): better background and UI color change description
fc371b2
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the Jerome-Herbinet-ui-colour-concept branch from acf2ea3 to fc371b2CompareMay 2, 2024 14:46
@skjnldsv
skjnldsv enabled auto-merge May 2, 2024 15:42
@skjnldsv
skjnldsv disabled auto-merge May 2, 2024 16:32
@skjnldsv
skjnldsv merged commit 6ead79e into masterMay 2, 2024
@skjnldsv
skjnldsv deleted the Jerome-Herbinet-ui-colour-concept branch May 2, 2024 16:32
@blizzzblizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardtjancborchardtjancborchardt approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@GretaDGretaDAwaiting requested review from GretaD
@nimishavijaynimishavijayAwaiting requested review from nimishavijay

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: theming

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

5 participants

@Jerome-Herbinet@skjnldsv@jancborchardt@blizzz@solracsf