Skip to content

[stable27] Store encrypted OAuth2 client secrets - #38707

Merged
julien-nc merged 2 commits into
stable27from
backport/38398/stable27
Jun 19, 2023
Merged

[stable27] Store encrypted OAuth2 client secrets#38707
julien-nc merged 2 commits into
stable27from
backport/38398/stable27

Conversation

@julien-nc

@julien-ncjulien-nc commented Jun 8, 2023

Copy link
Copy Markdown
Member

Manual backport of #38398 and #38701

I kept the original migration version so it does not reflect the actual app version.

@julien-ncjulien-nc added 3. to review Waiting for reviews security labels Jun 8, 2023
@julien-ncjulien-nc added this to the Nextcloud 27 milestone Jun 8, 2023
return null;
}

public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\OAuth2\Migration\Version011601Date20230522143227::postSchemaChange does not have a return type, expecting void
@julien-nc
julien-ncforce-pushed the backport/38398/stable27 branch from 715cce9 to 0c9ccb2CompareJune 9, 2023 08:28
@julien-nc
julien-nc requested review from a team, ArtificialOwl, icewind1991, kesselb, nfebe and szaimen and removed request for a teamJune 9, 2023 08:29

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzzblizzz mentioned this pull request Jun 12, 2023

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julien-nc
julien-ncforce-pushed the backport/38398/stable27 branch 2 times, most recently from f1b7112 to 39beecdCompareJune 12, 2023 15:11
@julien-nc
julien-ncforce-pushed the backport/38398/stable27 branch 2 times, most recently from 303537b to 8d72c77CompareJune 19, 2023 09:04
@julien-nc

Copy link
Copy Markdown
MemberAuthor

Failing Cypress tests are related with files_versions and theming.
https://github.com/nextcloud/server/actions/runs/5309936925/jobs/9611378026?pr=38707

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
julien-ncforce-pushed the backport/38398/stable27 branch from 8d72c77 to c18e42fCompareJune 19, 2023 11:12
@julien-nc
julien-nc merged commit d1aa03a into stable27Jun 19, 2023
@julien-nc
julien-nc deleted the backport/38398/stable27 branch June 19, 2023 11:12
@blizzzblizzz mentioned this pull request Jul 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewssecurity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@julien-nc@ChristophWurst@szaimen@github-advanced-security@skjnldsv