Skip to content

[stable26] Store encrypted OAuth2 client secrets - #38708

Merged
julien-nc merged 2 commits into
stable26from
backport/38398/stable26
Jun 22, 2023
Merged

[stable26] Store encrypted OAuth2 client secrets#38708
julien-nc merged 2 commits into
stable26from
backport/38398/stable26

Conversation

@julien-nc

@julien-ncjulien-nc commented Jun 8, 2023

Copy link
Copy Markdown
Member

Manual backport of #38398 and #38701

I kept the original migration version so it does not reflect the actual app version.

@julien-ncjulien-nc added 3. to review Waiting for reviews security labels Jun 8, 2023
@julien-ncjulien-nc added this to the Nextcloud 26.0.3 milestone Jun 8, 2023
@julien-nc
julien-ncforce-pushed the backport/38398/stable26 branch from d1eee8a to 262e9d7CompareJune 8, 2023 12:28
return null;
}

public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\OAuth2\Migration\Version011601Date20230522143227::postSchemaChange does not have a return type, expecting void
@julien-nc
julien-ncforce-pushed the backport/38398/stable26 branch from 262e9d7 to cb682d6CompareJune 9, 2023 08:27
@julien-nc
julien-nc requested review from a team, ArtificialOwl, icewind1991, kesselb, nfebe and szaimen and removed request for a teamJune 9, 2023 08:27

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzzblizzz mentioned this pull request Jun 12, 2023

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julien-nc
julien-ncforce-pushed the backport/38398/stable26 branch 2 times, most recently from da9a167 to 50ca447CompareJune 12, 2023 15:12
@julien-nc
julien-ncforce-pushed the backport/38398/stable26 branch from 9e2b82c to e00f507CompareJune 14, 2023 15:30
@blizzz

Copy link
Copy Markdown
Member

What about Cypress failing?

@blizzz

Copy link
Copy Markdown
Member

moving to 26.0.4

@julien-nc

julien-nc commented Jun 19, 2023

Copy link
Copy Markdown
MemberAuthor

@blizzz Failing Cypress tests are related with files_versions and theming.

jsunit failure seems unrelated too:
image

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
julien-ncforce-pushed the backport/38398/stable26 branch from ec284b1 to 5f461bcCompareJune 22, 2023 12:09
@julien-nc
julien-nc merged commit 913d9da into stable26Jun 22, 2023
@julien-nc
julien-nc deleted the backport/38398/stable26 branch June 22, 2023 15:09
@blizzzblizzz mentioned this pull request Jul 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewssecurity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@julien-nc@blizzz@ChristophWurst@szaimen@github-advanced-security