Skip to content

fix(carddav): Make SystemAddressBook::__construct $groupManager argument nullable - #38777

Merged
ChristophWurst merged 1 commit into
masterfrom
fix/carddav/system-address-book-nullable-groupmanager
Jun 13, 2023
Merged

fix(carddav): Make SystemAddressBook::__construct $groupManager argument nullable#38777
ChristophWurst merged 1 commit into
masterfrom
fix/carddav/system-address-book-nullable-groupmanager

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Jun 12, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Make PHP happy.

TODO

  • Do

Checklist

@ChristophWurst
fix(carddav): Make SystemAddressBook::__construct $groupManager argum…
62c4196
…ent nullable
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurstChristophWurst added bug 3. to review Waiting for reviews labels Jun 12, 2023
@ChristophWurstChristophWurst added this to the Nextcloud 28 milestone Jun 12, 2023
@ChristophWurstChristophWurst self-assigned this Jun 12, 2023
@ChristophWurst

ChristophWurst commented Jun 12, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@ChristophWurstChristophWurst mentioned this pull request Jun 12, 2023
Closed
8 tasks
@st3inyst3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 13, 2023
@st3iny

st3iny commented Jun 13, 2023

Copy link
Copy Markdown
Member

CI failure seems to be unrelated. Some jobs fail with: phpunit: command not found

@ChristophWurst
ChristophWurst merged commit 3f766e9 into masterJun 13, 2023
@ChristophWurst
ChristophWurst deleted the fix/carddav/system-address-book-nullable-groupmanager branch June 13, 2023 10:40
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jun 13, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3inyst3inyst3iny approved these changes
@miaulalalamiaulalalamiaulalala approved these changes
@hamza221hamza221hamza221 approved these changes
@JohannesGGEJohannesGGEAwaiting requested review from JohannesGGE
@tcitworldtcitworldAwaiting requested review from tcitworld

Assignees

@ChristophWurstChristophWurst

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 28

4 participants

@ChristophWurst@st3iny@miaulalala@hamza221