Skip to content

Enable version features again with S3 versioning - #38794

Merged
artonge merged 1 commit into
nextcloud:masterfrom
bensmrs:master
Jun 13, 2023
Merged

Enable version features again with S3 versioning#38794
artonge merged 1 commit into
nextcloud:masterfrom
bensmrs:master

Conversation

@bensmrs

@bensmrsbensmrs commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Summary

After nextcloud/files_versions_s3#28 is merged, we can enable version features with the S3 versioning backend again.

@bensmrs
Enable version features again with S3 versioning
75e0461
Signed-off-by: Benjamin Somers <bsomers@resel.fr>
@szaimen
szaimen requested review from a team, artonge, come-nc, icewind1991 and nfebe and removed request for a teamJune 13, 2023 13:25
@szaimenszaimen added the 3. to review Waiting for reviews label Jun 13, 2023
@szaimenszaimen added this to the Nextcloud 28 milestone Jun 13, 2023
artonge
artonge requested changes Jun 13, 2023
View reviewed changes

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is support for deleting and labeling versions was added to files_versions_s3?

@bensmrs

bensmrs commented Jun 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Is support for deleting and labeling versions was added to files_versions_s3?

Yes, it has been implemented by nextcloud/files_versions_s3#27

@artonge

artonge commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

Awesome @bensmrs. Can you fix DCO ?

@bensmrs

bensmrs commented Jun 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Hmmm I have several affiliations and the one I signed with is really the one that should appear… Any way for you to force the DCO without me having to switch my main email on GitHub (and switching it back to the current one 😓)?

@joshtrichards

joshtrichards commented Jun 13, 2023

Copy link
Copy Markdown
Member

@bensmrs You add other email addresses in GH without messing with your primary one:

https://github.com/settings/emails

@bensmrs

bensmrs commented Jun 13, 2023

Copy link
Copy Markdown
ContributorAuthor

It’s already the case…
IMG_8771

@artonge
artonge merged commit 69f6585 into nextcloud:masterJun 13, 2023
@welcome

welcomeBot commented Jun 13, 2023

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@artonge

artonge commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

Done @bensmrs, thanks a lot for pushing this !! 🎉

@icewind1991

icewind1991 commented Jul 4, 2023

Copy link
Copy Markdown
Member

/backport to stable27

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 4, 2023
Merged
@artongeartonge mentioned this pull request Jul 10, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991icewind1991icewind1991 approved these changes
@artongeartongeartonge approved these changes
@nfebenfebenfebe approved these changes
@come-nccome-ncAwaiting requested review from come-nccome-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

7 participants

@bensmrs@artonge@joshtrichards@icewind1991@nfebe@skjnldsv@szaimen