Skip to content

Add files actions testing + code coverage - #38806

Merged
skjnldsv merged 10 commits into
masterfrom
feat/f2v/actions-1
Jun 21, 2023
Merged

Add files actions testing + code coverage#38806
skjnldsv merged 10 commits into
masterfrom
feat/f2v/actions-1

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jun 14, 2023•
edited
Loading

Copy link
Copy Markdown
Member
  • Sidebar action
  • Delete action
  • Download action
  • Open folder action

Coverage: https://app.codecov.io/gh/nextcloud/server/pull/38806

-----------------------------|---------|----------|---------|---------|-------------------------------------------------------------File|%Stmts|%Branch|%Funcs|%Lines|UncoveredLine #s -----------------------------|---------|----------|---------|---------|-------------------------------------------------------------Allfiles|88.39|77.14|83.92|88.7|apps/dav/src/views|70.58|50|16.66|70.58|CalDavSettings.vue|70.58|50|16.66|70.58|128-320apps/files/src|0|0|0|0|logger.js|0|0|0|0|apps/files/src/actions|100|100|100|100|deleteAction.ts|100|100|100|100|downloadAction.ts|100|100|100|100|openFolderAction.ts|100|100|100|100|sidebarAction.ts|100|100|100|100|apps/files/src/services|65.95|55.88|73.33|65.9|FileAction.ts|65.95|55.88|73.33|65.9|117-121,126,130,134,138,143,147,151,155,159,163,177-178,185apps/files_sharing/src/lib|100|100|100|100|SharePermissionsToolBox.js|100|100|100|100|core/src/OC|100|100|100|100|requesttoken.js|100|100|100|100|-----------------------------|---------|----------|---------|---------|-------------------------------------------------------------

@skjnldsvskjnldsv added this to the Nextcloud 28 milestone Jun 14, 2023
@skjnldsvskjnldsv self-assigned this Jun 14, 2023
@skjnldsv
skjnldsvforce-pushed the feat/f2v/actions-1 branch from 0f6794e to cfc691bCompareJune 20, 2023 10:05
@skjnldsvskjnldsv changed the title [wip] fix: delete action import[wip] Add files actions testingJun 20, 2023
@skjnldsv
skjnldsvforce-pushed the feat/f2v/actions-1 branch from 408d209 to c9ab5a3CompareJune 20, 2023 14:45
@skjnldsv
skjnldsv requested review from a team, Pytal, artonge and susnux and removed request for a teamJune 20, 2023 14:49
@skjnldsv
skjnldsv marked this pull request as ready for review June 20, 2023 14:49
@skjnldsvskjnldsv changed the title [wip] Add files actions testingAdd files actions testingJun 20, 2023
@skjnldsvskjnldsv added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 and removed 2. developing Work in progress labels Jun 20, 2023
@skjnldsv
skjnldsvforce-pushed the feat/f2v/actions-1 branch from c9ab5a3 to 373be9fCompareJune 20, 2023 14:53
@skjnldsv

This comment was marked as resolved.

Sign in to view
artonge
artonge reviewed Jun 20, 2023
View reviewed changes
Comment threadjest.config.ts
Comment threadapps/files/src/actions/deleteAction.spec.ts
@skjnldsv
skjnldsv requested a review from artongeJune 20, 2023 16:31
@skjnldsvskjnldsv mentioned this pull request Jun 2, 2023
Closed
6 tasks
@skjnldsv
fix: delete action import
8b5ef98
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat: prepare jest upgrade and ts testing
f8e697c
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat: add sidebar action testing
c31b232
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat: add delete action testing
9fbdc00
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the feat/f2v/actions-1 branch 2 times, most recently from ddf48c4 to 7a7558eCompareJune 21, 2023 07:19
@skjnldsv
feat: add download action testing
1b0848a
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat: add open folder action testing
8096315
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
fix(jest): replace mock with jest.spyOn
70ee8de
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat: prepare jest coverage support
45ecd55
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the feat/f2v/actions-1 branch from 7a7558e to 45ecd55CompareJune 21, 2023 07:21
@skjnldsvskjnldsv changed the title Add files actions testingAdd files actions testing + code coverageJun 21, 2023
@skjnldsv
chore: update old codecov config
8971148
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the feat/f2v/actions-1 branch from d32a7d1 to 8971148CompareJune 21, 2023 07:28
@skjnldsv
chore: add __tests__ and __mocks__ to file checker and fix update…
a70aa61
…d names
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
nickvergessen
nickvergessen reviewed Jun 21, 2023
View reviewed changes
Comment thread.gitignore
nickvergessen
nickvergessen approved these changes Jun 21, 2023
View reviewed changes

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks okay and still renders

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 21, 2023
@skjnldsv
skjnldsv merged commit 32bbe3d into masterJun 21, 2023
@skjnldsv
skjnldsv deleted the feat/f2v/actions-1 branch June 21, 2023 09:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@artongeartongeartonge approved these changes
@susnuxsusnuxAwaiting requested review from susnuxsusnux is a code owner automatically assigned from nextcloud/server-frontend
@PytalPytalAwaiting requested review from PytalPytal is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: filestechnical debt🧱 🤔🚀

Projects

Files to vue
Status: Done

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@nickvergessen@artonge