fix(sab): put location in proper address field

[JohannesGGE]

• Resolves: Unstructured address shows all value at "Post office box" contacts#3404

Summary

before	after

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[tcitworld]

Code-wise that's good, but it wasn't assumed the profile Location field was a city before, so this seems a little problematic for people who entered a full street address in that field. 🤷

[ChristophWurst]

it wasn't assumed the profile Location field was a city before, so this seems a little problematic for people who entered a full street address in that field.

Yeah. I think no matter how we name or hint the profile property, it's never going to be perfect.

Ref nextcloud/contacts#3404 (comment)

[tcitworld]

Thx for context!

[ChristophWurst]

Suggested change

	$vCard->add(new Text($vCard, 'ADR', [null, null, null, $property->getValue(), null, null, null],
	['TYPE' => 'OTHER', 'X-NC-SCOPE' => $scope]));
	$vCard->add(
	new Text(
	$vCard,
	'ADR',
	[ null, null, null, $property->getValue(), null, null, null ],
	[
	'TYPE' => 'OTHER',
	'X-NC-SCOPE' => $scope,
	],
	)
	);

My take at formatting this long line 😄

[ChristophWurst]

/backport to stable27

[JohannesGGE]

Replaced null with '' to make pipeline (phpunit) happy

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport