Skip to content

file scanner performance improvements - #38858

Merged
icewind1991 merged 1 commit into
masterfrom
scanner-performance3
Jun 26, 2023
Merged

file scanner performance improvements#38858
icewind1991 merged 1 commit into
masterfrom
scanner-performance3

Conversation

@icewind1991

@icewind1991icewind1991 commented Jun 16, 2023

Copy link
Copy Markdown
Member
  • Fixes some invalid logic around re-using known folder ids that was causing an extra select for every folder scanned
  • Properly forward known folder sizes during recursive scan, saving a select and an update for every folder scanned
  • Make scanChildren parameters non-option to simplify reasoning

Comparison scanning 23239 files over 466 folders

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Jun 16, 2023
@icewind1991icewind1991 added this to the Nextcloud 28 milestone Jun 16, 2023
@icewind1991
icewind1991 requested review from a team, ArtificialOwl, come-nc and nfebe and removed request for a teamJune 16, 2023 14:12
@icewind1991
icewind1991force-pushed the scanner-performance3 branch 3 times, most recently from e054578 to a535fc6CompareJune 16, 2023 14:30
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the scanner-performance3 branch from a535fc6 to 561536fCompareJune 16, 2023 14:31
@icewind1991
icewind1991 marked this pull request as ready for review June 16, 2023 15:57
@icewind1991
icewind1991 requested a review from artongeJune 21, 2023 15:22
@icewind1991
icewind1991 merged commit 39a0554 into masterJun 26, 2023
@icewind1991
icewind1991 deleted the scanner-performance3 branch June 26, 2023 15:01
@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsperformance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@artonge@come-nc@solracsf@skjnldsv