Uh oh!
There was an error while loading. Please reload this page.
fix confusion around mail settings and improve layout a bit - #38868
Merged
Conversation
szaimenforce-pushed
the
enh/noid/fix-mail-confusion
branch
from
June 17, 2023 16:18
61c0322 to
eb1afa8CompareSigned-off-by: Simon L <szaimen@e.mail.de>
szaimenforce-pushed
the
enh/noid/fix-mail-confusion
branch
from
June 17, 2023 16:26
eb1afa8 to
7918bb1Compare| </p> | ||
| <label id="mail_sendmailmode_label" for="mail_sendmailmode" class="<?= $_['mail_smtpmode'] !== 'sendmail' ? 'hidden' : '' ?>"> | ||
| <p class="<?= $_['mail_smtpmode'] !== 'sendmail' ? 'hidden' : '' ?>"> |
Check notice
Code scanning / Psalm
PossiblyUndefinedArrayOffset
1 task
szaimen
marked this pull request as ready for review
June 17, 2023 16:46
szaimen
commented
Jun 17, 2023
ContributorAuthor
/backport to stable27 |
szaimen
commented
Jun 17, 2023
ContributorAuthor
/backport to stable26 |
szaimen
requested review from
ChristophWurst, come-nc, jancborchardt, marcoambrosini, miaulalala and nimishavijayJune 17, 2023 16:49
come-nc
approved these changes
Jun 19, 2023
come-nc
left a comment
Contributor
There was a problem hiding this comment.
👍 on the wording, not sure I understand all the code changes. Did not test.
marcoambrosini
approved these changes
Jun 19, 2023
This was referenced Jun 19, 2023
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.