Skip to content

[stable27] fix(core): Do not invert app menu text color - #38897

Merged
mejo- merged 2 commits into
stable27from
fix/inverted-text-color-stable27
Jun 20, 2023
Merged

[stable27] fix(core): Do not invert app menu text color#38897
mejo- merged 2 commits into
stable27from
fix/inverted-text-color-stable27

Conversation

@Hephi2

@Hephi2Hephi2 commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

Fixes#38759
Backport of #38776

@Hephi2
Hephi2 requested a review from mejo-June 19, 2023 10:57
@Hephi2Hephi2 changed the title fix(core): Do not invert app menu text color[stable27] fix(core): Do not invert app menu text colorJun 19, 2023
@mejo-
mejo-force-pushed the fix/inverted-text-color-stable27 branch from d78d695 to aaca0cdCompareJune 19, 2023 13:57
@mejo-

Copy link
Copy Markdown
Member

Cypress test failures seem unrelated. The last merge to stable27 also failed to run any Cypress e2e tests: https://github.com/nextcloud/server/actions/runs/5311915284/jobs/9615820016

@mejo-

Copy link
Copy Markdown
Member

I have no idea why the psalm test fails. Apparently it didn't fail on former stable27 PRs, but this PR doesn't touch anything related 🤔

Comment threadcore/src/components/AppMenu.vue

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3rdparty should not get updated here

@Hephi2
Hephi2force-pushed the fix/inverted-text-color-stable27 branch from aaca0cd to 2ba9773CompareJune 20, 2023 07:14
@juliusknorrjuliusknorr added this to the Nextcloud 27.0.1 milestone Jun 20, 2023
@juliusknorr

Copy link
Copy Markdown
Member

@Hephi2 Can you check #38897 (comment) ? :)

@Hephi2
Hephi2force-pushed the fix/inverted-text-color-stable27 branch from 2ba9773 to 76f35d0CompareJune 20, 2023 08:44
susnuxand others added 2 commits June 20, 2023 11:10
* Also fixes other cypress test
* Build assets
Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de>
@Hephi2
Hephi2force-pushed the fix/inverted-text-color-stable27 branch from 9260bce to 7fb287cCompareJune 20, 2023 09:15
@Hephi2
Hephi2 requested a review from szaimenJune 20, 2023 09:16

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport looks good

@Hephi2

Copy link
Copy Markdown
ContributorAuthor

/backport cdea2d0 to stable26

@mejo-
mejo- merged commit 870e599 into stable27Jun 20, 2023
@mejo-
mejo- deleted the fix/inverted-text-color-stable27 branch June 20, 2023 11:17
@blizzzblizzz mentioned this pull request Jul 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Hephi2@mejo-@juliusknorr@szaimen@susnux