Uh oh!
There was an error while loading. Please reload this page.
Reduce load of files versions preview loading - #38905
Merged
artonge merged 4 commits intoJun 30, 2023
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
artonge
commented
Jun 19, 2023
CollaboratorAuthor
/backport to stable27 |
artongeforce-pushed
the
artonge/feat/improve_files_versions_preview_logic
branch
from
June 19, 2023 16:40
635ee3b to
f6be02eCompareartongeforce-pushed
the
artonge/feat/improve_files_versions_preview_logic
branch
from
June 28, 2023 14:44
2cfb3c8 to
fe42647CompareThis allow to no request non existing previews I also set some properties to the img element to reduce preview loading to what the browser think is necessary Signed-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
artonge/feat/improve_files_versions_preview_logic
branch
from
June 28, 2023 14:49
fe42647 to
b93c084CompareUh oh!
There was an error while loading. Please reload this page.
skjnldsv
approved these changes
Jun 28, 2023
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
artonge/feat/improve_files_versions_preview_logic
branch
from
June 28, 2023 15:00
b93c084 to
505a11bCompare| if ($user !== null) { | ||
| $propFind->handle(FilesPlugin::HAS_PREVIEW_PROPERTYNAME, function () use ($node, $user) { | ||
| try { | ||
| $this->versionManager->getVersionFile( |
Member
There was a problem hiding this comment.
I would have to double check, but I feel that this is somewhat expensive for the info we're trying to get here.
Preview availability is mostly determined by the mimetype, which you can get directly from the $node
CollaboratorAuthor
There was a problem hiding this comment.
Go idea, I changed the logic to use $previewManager->isMimeSupported(...)
artongeforce-pushed
the
artonge/feat/improve_files_versions_preview_logic
branch
from
June 29, 2023 10:07
d7f87e7 to
6d6e274CompareSigned-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
artonge/feat/improve_files_versions_preview_logic
branch
from
June 29, 2023 10:09
6d6e274 to
05acd91ComparePytal
approved these changes
Jun 30, 2023
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<img>element to reduce preview loading to what the browser think is necessaryEspecially useful when there are a lot of versions.