Skip to content

[f2v] Rename, favorite and edit locally actions - #38939

Merged
skjnldsv merged 5 commits into
masterfrom
feat/f2v/more-actions
Jun 22, 2023
Merged

[f2v] Rename, favorite and edit locally actions#38939
skjnldsv merged 5 commits into
masterfrom
feat/f2v/more-actions

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jun 22, 2023•
edited
Loading

Copy link
Copy Markdown
Member
  • Edit locally
  • Favorite
  • Rename

Coverage 100%

-----------------------------|---------|----------|---------|---------|-------------------------------------------------------------File|%Stmts|%Branch|%Funcs|%Lines|UncoveredLine #s -----------------------------|---------|----------|---------|---------|-------------------------------------------------------------Allfiles|100|100|100|100|apps/files/src/actions|100|100|100|100|deleteAction.ts|100|100|100|100|downloadAction.ts|100|100|100|100|editLocallyAction.ts|100|100|100|100|favoriteAction.ts|100|100|100|100|openFolderAction.ts|100|100|100|100|renameAction.ts|100|100|100|100|sidebarAction.ts|100|100|100|100|-----------------------------|---------|----------|---------|---------|-------------------------------------------------------------

@skjnldsvskjnldsv added this to the Nextcloud 28 milestone Jun 22, 2023
@skjnldsv
skjnldsv requested a review from a teamJune 22, 2023 08:40
@skjnldsvskjnldsv self-assigned this Jun 22, 2023
@skjnldsv
skjnldsv requested review from Pytal, nfebe and susnux and removed request for a teamJune 22, 2023 08:40
@skjnldsvskjnldsv changed the title feat: add edit locally action with tests[f2v] Rename, favorite and edit locally actionsJun 22, 2023
@skjnldsvskjnldsv mentioned this pull request Jun 22, 2023
Closed
6 tasks
@skjnldsv
feat: add edit locally action with tests
1112963
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the feat/f2v/more-actions branch from 47d1f59 to 1adff7cCompareJune 22, 2023 08:47
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv
skjnldsvforce-pushed the feat/f2v/more-actions branch from 45eb719 to 122c4c2CompareJune 22, 2023 09:17
@skjnldsv
skjnldsv requested a review from artongeJune 22, 2023 09:51
artonge
artonge reviewed Jun 22, 2023
View reviewed changes
Comment threadapps/files/src/actions/renameAction.ts
Comment threadapps/files/src/actions/favoriteAction.ts Outdated
Comment threadapps/files/src/actions/editLocallyAction.ts
Comment threadapps/files/src/actions/favoriteAction.ts
@skjnldsv
feat: add favorite action with tests
723edb5
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
fix(files): action default is false if not set
05bfab2
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat: add rename action with tests
135929c
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the feat/f2v/more-actions branch from 122c4c2 to 55a439fCompareJune 22, 2023 16:35
@skjnldsv
skjnldsv requested a review from artongeJune 22, 2023 16:37
@skjnldsv

This comment was marked as resolved.

Sign in to view
@nextcloud-command
chore(assets): Recompile assets
cbc0f5e
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
skjnldsv enabled auto-merge June 22, 2023 18:33
susnux
susnux approved these changes Jun 22, 2023
View reviewed changes

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@skjnldsv
skjnldsv merged commit 6234b09 into masterJun 22, 2023
@skjnldsv
skjnldsv deleted the feat/f2v/more-actions branch June 22, 2023 20:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@artongeartongeartonge approved these changes
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-frontend
@PytalPytalAwaiting requested review from PytalPytal is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsenhancement

Projects

Files to vue
Status: Done

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@susnux@artonge@nextcloud-command