Skip to content

fix: restore AppsSlideToggle feature - #38988

Merged
szaimen merged 1 commit into
masterfrom
fix/data-apps-slide-toggle
Jun 25, 2023
Merged

fix: restore AppsSlideToggle feature#38988
szaimen merged 1 commit into
masterfrom
fix/data-apps-slide-toggle

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

@skjnldsvskjnldsv added this to the Nextcloud 28 milestone Jun 25, 2023
@skjnldsv
skjnldsv requested review from a team and solracsfJune 25, 2023 09:53
@skjnldsvskjnldsv self-assigned this Jun 25, 2023
@skjnldsv
skjnldsv requested review from Pytal, nfebe and susnux and removed request for a teamJune 25, 2023 09:53
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@nextcloud-command
nextcloud-commandforce-pushed the fix/data-apps-slide-toggle branch from 2599554 to f646f1eCompareJune 25, 2023 10:07

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is OC not (theoretically) private API? (just asking because in this case probably those apps should migrate?)

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Is OC not (theoretically) private API? (just asking because in this case probably those apps should migrate?)

Those apps should indeed migrate, but we need to properly deprecate and publish some documents with an alternative

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
skjnldsvforce-pushed the fix/data-apps-slide-toggle branch from f646f1e to adff75dCompareJune 25, 2023 13:39

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@szaimen
szaimen enabled auto-merge June 25, 2023 14:08
@szaimen
szaimen merged commit 72156d7 into masterJun 25, 2023
@szaimen
szaimen deleted the fix/data-apps-slide-toggle branch June 25, 2023 14:16
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen

Copy link
Copy Markdown
Contributor

/backport to stable27

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ShGKme

Copy link
Copy Markdown
Contributor

Those apps should indeed migrate, but we need to properly deprecate and publish some documents with an alternative

@skjnldsv So, should we deprecate it in Nextcloud 29?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugregression

Projects

None yet

4 participants

@skjnldsv@szaimen@ShGKme@susnux