Uh oh!
There was an error while loading. Please reload this page.
fix(files): Only render the menu if there are actions to show - #39025
Merged
Conversation
juliusknorr
requested review from
a team, Pytal, artonge and susnux
and removed request for
a teamJune 27, 2023 08:48
juliusknorr
commented
Jun 27, 2023
MemberAuthor
/backport to stable27 |
juliusknorr
commented
Jun 27, 2023
MemberAuthor
/backport to stable26 |
juliusknorr
commented
Jun 27, 2023
MemberAuthor
/backport to stable25 |
artonge
approved these changes
Jun 27, 2023
Pytal
approved these changes
Jun 27, 2023
susnux
approved these changes
Jun 27, 2023
juliusknorrforce-pushed
the
bugfix/noid/actions-empty-files
branch
from
June 29, 2023 17:16
737530c to
bfb7aadCompareSigned-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorrforce-pushed
the
bugfix/noid/actions-empty-files
branch
from
June 29, 2023 18:27
bfb7aad to
40b380bComparejuliusknorr
commented
Jun 30, 2023
MemberAuthor
Samba failure unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filter action list that is used to determine if the actions menu should be visible properly so that:
Steps to reproduce:
This change will make sure that we don't show the 3 dots menu for the files in the share as the only option available is "View" which is not in the menu as it is the default. Before that an empty menu was shown.
Checklist