Skip to content

enh(a11y): Users table - #39050

Merged
Pytal merged 7 commits into
masterfrom
enh/a11y-users-table
Jul 13, 2023
Merged

enh(a11y): Users table#39050
Pytal merged 7 commits into
masterfrom
enh/a11y-users-table

Conversation

@Pytal

@PytalPytal commented Jun 29, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Screenshot
Beforeimage
Afterimage
Beforeimage
Afterimage

TODO

  • Tests

Checklist

@PytalPytal added the 2. developing Work in progress label Jun 29, 2023
@PytalPytal added this to the Nextcloud 28 milestone Jun 29, 2023
@PytalPytal self-assigned this Jun 29, 2023
@PytalPytal mentioned this pull request Jun 29, 2023
Closed
2 tasks
@Pytal
Pytalforce-pushed the enh/a11y-users-table branch 5 times, most recently from 52e7aca to 9294f73CompareJuly 6, 2023 01:13
@PytalPytal changed the title [WIP] Users tableenh(a11y): Users tableJul 6, 2023
@Pytal
Pytal marked this pull request as ready for review July 6, 2023 01:27
@PytalPytal mentioned this pull request Jul 6, 2023
Closed
4 tasks
@Pytal
Pytalforce-pushed the enh/a11y-users-table branch from 9294f73 to 8b10788CompareJuly 8, 2023 00:30
@Pytal
Pytalforce-pushed the enh/a11y-users-table branch from 8b10788 to 363463aCompareJuly 12, 2023 05:23
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Jul 12, 2023
View reviewed changes

@JuliaKirschenheuterJuliaKirschenheuter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@JuliaKirschenheuterJuliaKirschenheuter mentioned this pull request Jul 12, 2023
Closed
9 tasks
@Pytal
enh(a11y): Users table
cbfe0c6
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal added 4 commits July 12, 2023 17:30
@Pytal
chore: Compile assets
821fcc6
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(cypress): users_disable
957dbee
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(cypress): users_modify
b65eb0c
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(cypress): users
ce99dd9
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the enh/a11y-users-table branch from 363463a to 60c55a0CompareJuly 13, 2023 00:35
@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 13, 2023
Pytal added 2 commits July 12, 2023 21:35
@Pytal
fix(acceptance): UsersSettingsContext
8faa1a4
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
test(settings): Users table
faf2b23
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the enh/a11y-users-table branch from 60c55a0 to faf2b23CompareJuly 13, 2023 04:36
@Pytal
Pytal merged commit 41540ad into masterJul 13, 2023
@Pytal
Pytal deleted the enh/a11y-users-table branch July 13, 2023 05:29
@PytalPytal linked an issue Jul 18, 2023 that may be closed by this pull request
[BITV] 9.1.3.1e/8.1 - The user table represents a grid element and should be implemented as such. (1) #36921
Closed
2 tasks
@nickvergessennickvergessen mentioned this pull request Nov 8, 2023
Closed
@FantuFantu mentioned this pull request Jul 13, 2026
Draft
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@JuliaKirschenheuterJuliaKirschenheuterJuliaKirschenheuter approved these changes
@artongeartongeartonge approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@nfebenfebeAwaiting requested review from nfebe

Assignees

@PytalPytal

Labels

4. to releaseReady to be released and/or waiting for tests to finishaccessibilityenhancementfeature: users and groups

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

[BITV] 9.1.3.1e/8.1 - The user table represents a grid element and should be implemented as such. (1)

5 participants

@Pytal@susnux@JuliaKirschenheuter@artonge@skjnldsv