Skip to content

Silent imagecreatefromstring() errors - #39093

Merged
solracsf merged 1 commit into
masterfrom
imageCreateFromString
Jul 1, 2023
Merged

Silent imagecreatefromstring() errors#39093
solracsf merged 1 commit into
masterfrom
imageCreateFromString

Conversation

@solracsf

@solracsfsolracsf commented Jun 30, 2023

Copy link
Copy Markdown
Member

Summary

There isn't much we can do about, and all other calls to this same function on the same file are already silent.

Error: imagecreatefromstring(): Data is not in a recognized format at /lib/private/legacy/OC_Image.php#758

Checklist

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsfsolracsf added the 3. to review Waiting for reviews label Jun 30, 2023
@solracsfsolracsf added this to the Nextcloud 28 milestone Jun 30, 2023
@kesselb

Copy link
Copy Markdown
Contributor

Thanks for your pr 👍

I thought you didn't like the silent operator? 😃

@kesselb
kesselb requested review from nfebe and szaimenJune 30, 2023 21:42
@kesselbkesselb added the bug label Jun 30, 2023
@solracsf

solracsf commented Jun 30, 2023

Copy link
Copy Markdown
MemberAuthor

I thought you didn't like the silent operator?

I can make an effort for previews 😝

@nfebe

Copy link
Copy Markdown
Contributor

I thought you didn't like the silent operator? 😃

Add me to the list.

@solracsf

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@solracsf

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@solracsf

Copy link
Copy Markdown
MemberAuthor

/backport to stable25

@joshtrichards

Copy link
Copy Markdown
Member

Possibly fixes (at least partially): #36244 and possibly exacerbates or hides (or fixes? hah) whatever #37044 is.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@solracsf@kesselb@nfebe@joshtrichards