Uh oh!
There was an error while loading. Please reload this page.
fix(ldap): avatar is not being fetched - #39128
Merged
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzzforce-pushed
the
fix/35319/ldap-missing-avatar
branch
from
July 5, 2023 15:14
96d7404 to
92a082dCompareblizzz
requested review from
a team, ArtificialOwl and icewind1991
and removed request for
a teamJuly 5, 2023 15:15
blizzz
commented
Jul 5, 2023
MemberAuthor
/backport to stable27 |
blizzz
commented
Jul 5, 2023
MemberAuthor
/backport to stable26 |
blizzz
commented
Jul 5, 2023
MemberAuthor
/backport to stable25 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzzforce-pushed
the
fix/35319/ldap-missing-avatar
branch
from
July 7, 2023 08:46
ffb52d9 to
4054a7dComparejuliusknorr
approved these changes
Sep 11, 2023
juliusknorr
commented
Sep 11, 2023
Member
Failure unrelated |
This was referenced Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before leaving early, double check whether the avatar is actually present.
This is a quick attempt based on this observation #35319 (comment),
but I have not tested it yet.Tested now and working.
TODO
Checklist