Uh oh!
There was an error while loading. Please reload this page.
Support opening and comparing versions in viewer - #39171
Merged
juliusknorr merged 2 commits intoAug 8, 2023
Merged
Conversation
artongeforce-pushed
the
artonge/feat/allow_to_open_versions_in_viewer
branch
from
July 6, 2023 15:02
b26cb7c to
81ce076Compare
This was referenced Jul 6, 2023
artongeforce-pushed
the
artonge/feat/allow_to_open_versions_in_viewer
branch
from
July 13, 2023 16:16
81ce076 to
c148c5aComparejuliusknorrforce-pushed
the
artonge/feat/allow_to_open_versions_in_viewer
branch
from
August 3, 2023 13:14
c148c5a to
64c5835Compare
This was referenced Aug 3, 2023
juliusknorrforce-pushed
the
artonge/feat/allow_to_open_versions_in_viewer
branch
from
August 4, 2023 07:41
397567d to
81d89f1Comparejuliusknorr
marked this pull request as ready for review
August 7, 2023 08:19
juliusknorrforce-pushed
the
artonge/feat/allow_to_open_versions_in_viewer
branch
from
August 7, 2023 08:19
81d89f1 to
4611ce2CompareUh oh!
There was an error while loading. Please reload this page.
juliusknorrforce-pushed
the
artonge/feat/allow_to_open_versions_in_viewer
branch
from
August 7, 2023 10:34
4611ce2 to
92d7b38Comparejuliusknorr
approved these changes
Aug 7, 2023
juliusknorr
requested review from
a team, Pytal, max-nextcloud, nfebe and susnux
and removed request for
a teamAugust 7, 2023 17:18
susnux
approved these changes
Aug 8, 2023
max-nextcloud
approved these changes
Aug 8, 2023
juliusknorrforce-pushed
the
artonge/feat/allow_to_open_versions_in_viewer
branch
from
August 8, 2023 14:29
92d7b38 to
872843cComparejuliusknorr
commented
Aug 8, 2023
Member
/compile |
Signed-off-by: Louis Chemineau <louis@chmn.me>
juliusknorrforce-pushed
the
artonge/feat/allow_to_open_versions_in_viewer
branch
from
August 8, 2023 19:19
c7d8439 to
5902325Comparejuliusknorr
commented
Aug 8, 2023
Member
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
juliusknorr
commented
Aug 8, 2023
Member
/backport 5902325 to stable27 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
AndyScherzinger
commented
Aug 8, 2023
Member
/backport 5902325 to stable27 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
AndyScherzinger
commented
Aug 8, 2023
Member
Backport bot is no friend of mine nor of @juliushaertl 😭 |
This was referenced Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#39139
Fix#39140
Tests will be added in text as there is no default viewer handler that covers version comparison support for now
Screenshots
Clicking the version just opens a single preview
Comparing menu
Comparing is available for any but the current version

Clicking it will compare the picked with the current version

Todo