Uh oh!
There was an error while loading. Please reload this page.
Refactor core/Command/Background - #39184
Merged
skjnldsv merged 3 commits intoFeb 23, 2024
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
skjnldsv
approved these changes
Jul 7, 2023
Uh oh!
There was an error while loading. Please reload this page.
ChristophWurst
approved these changes
Jul 7, 2023
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Squash your commits into one please
👍 thanks
Merged
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com> Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com> Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
skjnldsvforce-pushed
the
refactor_core_command_background
branch
from
February 23, 2024 15:57
607f75e to
7062314Compareskjnldsv
enabled auto-merge
February 23, 2024 15:58
skjnldsv
disabled auto-merge
February 23, 2024 20:31
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The required adjustments have been made to the classes in
/core/Command/Backgroundnamespace.The improvements:
Checklist