Uh oh!
There was an error while loading. Please reload this page.
Refactor "substr" calls in dav app to improve code readability - #39214
Merged
skjnldsv merged 1 commit intoFeb 23, 2024
Conversation
shdehnavi
requested review from
ChristophWurst, miaulalala and tcitworld
as code ownersJuly 7, 2023 01:09
ChristophWurst
approved these changes
Jul 7, 2023
tcitworld
approved these changes
Jul 8, 2023
miaulalala
commented
Aug 16, 2023
Contributor
/rebase |
nextcloud-commandforce-pushed
the
replace_substr_calls_in_dav_app
branch
from
August 16, 2023 07:02
5b2859b to
a85bafdCompare Merged
shdehnaviforce-pushed
the
replace_substr_calls_in_dav_app
branch
from
December 11, 2023 12:43
a85bafd to
b131f16Compareshdehnavi
commented
Dec 11, 2023
ContributorAuthor
@blizzz All conflicts have been resolved, Could you merge this PR? |
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
skjnldsvforce-pushed
the
replace_substr_calls_in_dav_app
branch
from
February 23, 2024 14:54
b131f16 to
7bf31dfCompareskjnldsv
enabled auto-merge
February 23, 2024 14:54
skjnldsv
disabled auto-merge
February 23, 2024 18:32
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replacing
substrwithstr_starts_withandstr_ends_within thedavapp to improve code readabilityChecklist