Skip to content

(occ db:convert-type) Add support for UNIX sockets - #39242

Merged
skjnldsv merged 1 commit into
nextcloud:masterfrom
joshtrichards:db-convert-type-mysql-socket-no-pw
Sep 4, 2024
Merged

(occ db:convert-type) Add support for UNIX sockets#39242
skjnldsv merged 1 commit into
nextcloud:masterfrom
joshtrichards:db-convert-type-mysql-socket-no-pw

Conversation

@joshtrichards

@joshtrichardsjoshtrichards commented Jul 8, 2023•
edited by susnux
Loading

Copy link
Copy Markdown
Member

Summary

Adds support to occ db:convert-type to support UNIX socket connections via MySQL/MariaDB:

  • Uses same dbhost / hostname parameter parsing logic (adapted) as used elsewhere (at least the relevant parts) for consistency.
  • Adds UI support for non-passworded connections.

Checklist

@solracsfsolracsf added the 3. to review Waiting for reviews label Jul 9, 2023
@solracsfsolracsf added this to the Nextcloud 28 milestone Jul 9, 2023
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jul 9, 2023
View reviewed changes
Comment threadcore/Command/Db/ConvertType.php Fixed
@szaimen
szaimen requested review from a team, ArtificialOwl, icewind1991 and nfebe and removed request for a teamJuly 13, 2023 16:16
nfebe
nfebe reviewed Jul 14, 2023
View reviewed changes
Comment threadcore/Command/Db/ConvertType.php Outdated
nfebe
nfebe reviewed Jul 14, 2023
View reviewed changes

@nfebenfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay though I left an inline suggestion. Do you mind using regex instead?

@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@joshtrichardsjoshtrichards mentioned this pull request Feb 25, 2024
Merged
@AndyScherzinger
AndyScherzingerforce-pushed the db-convert-type-mysql-socket-no-pw branch from 864c17c to 1ac39e7CompareFebruary 27, 2024 13:25
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsvskjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity labels Jul 27, 2024
@skjnldsvskjnldsv removed the 3. to review Waiting for reviews label Jul 27, 2024
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsvskjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv

skjnldsv commented Aug 16, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Hey @joshtrichards
We cleaned up some old staled PRs! But a quick look at this PR seems like a good candidate for an update, let me take over to help you get it merge in 31! 💪 🤗

@skjnldsvskjnldsv reopened this Aug 16, 2024
@nextcloudnextcloud deleted a comment from backportbotBotAug 16, 2024
@joshtrichards@skjnldsv
fix(occ): Add support for UNIX sockets to db:convert-type
71fff03
Fixesnextcloud#31998
Adds support to `occ db:convert-type` to support UNIX socket connections via MySQL/MariaDB. Uses same `dbhost` / `hostname` parameter parsing logic (adapted) as used elsewhere (at least the relevant parts) for consistency.
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@skjnldsvskjnldsv removed stale Ticket or PR with no recent activity backport-request labels Aug 16, 2024
@skjnldsv
skjnldsvforce-pushed the db-convert-type-mysql-socket-no-pw branch from 1ac39e7 to 71fff03CompareAugust 16, 2024 07:16
@skjnldsv
skjnldsv requested a review from nfebeAugust 16, 2024 07:18
nfebe
nfebe approved these changes Aug 16, 2024
View reviewed changes

@nfebenfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susnux

susnux commented Aug 31, 2024

Copy link
Copy Markdown
Contributor

@joshtrichards as you are a member of Nextcloud organization, could you maybe move this into a local branch? Some CI does not work on forks 😔

@skjnldsv
skjnldsv merged commit c28340d into nextcloud:masterSep 4, 2024
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 4, 2024
@skjnldsv

skjnldsv commented Sep 4, 2024

Copy link
Copy Markdown
Member

Merged, anyway, tests passed locally for me

@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
@provokateurinprovokateurin mentioned this pull request Jan 29, 2025
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfebenfebenfebe approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: db:convert-type does not support mysql passwordless unix socket auth

8 participants

@joshtrichards@skjnldsv@susnux@nfebe@github-advanced-security@blizzz@solracsf@szaimen